Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Partially revert np.int_ changes #55540

Merged
merged 1 commit into from
Oct 16, 2023
Merged

MAINT: Partially revert np.int_ changes #55540

merged 1 commit into from
Oct 16, 2023

Conversation

mtsokol
Copy link
Contributor

@mtsokol mtsokol commented Oct 16, 2023

Hi!

This PR reverts some changes introduced in #55369 that, after discussions, are outdated (np.long should be used in places that specifically refer to the C type, rather than just "default integer").

@mtsokol mtsokol mentioned this pull request Oct 16, 2023
Closed
@mroeschke mroeschke added the Compat pandas objects compatability with Numpy or Python functions label Oct 16, 2023
@mroeschke mroeschke added this to the 2.1.2 milestone Oct 16, 2023
@mroeschke mroeschke merged commit e61a0a8 into pandas-dev:main Oct 16, 2023
@mroeschke
Copy link
Member

Thanks @mtsokol

@meeseeksmachine meeseeksmachine mentioned this pull request Oct 16, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Oct 16, 2023
@mtsokol @meeseeksmachine
Backport PR pandas-dev#55540: MAINT: Partially revert np.int_ changes
d4481fe
mroeschke pushed a commit that referenced this pull request Oct 16, 2023
@meeseeksmachine @mtsokol
Backport PR #55540 on branch 2.1.x (MAINT: Partially revert np.int_…
c9053cc 
… changes) (#55545)

Backport PR #55540: MAINT: Partially revert `np.int_` changes

Co-authored-by: Mateusz Sokół <8431159+mtsokol@users.noreply.github.com>
@mtsokol mtsokol deleted the int_-partial-revert branch October 16, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Milestone
2.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@mtsokol @mroeschke