ENH/WIP: resolution inference in pd.to_datetime, DatetimeIndex #55901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
added
the
Non-Nano
This was referenced Nov 13, 2023
jbrockmendel
force-pushed
the
enh-array_to_datetime-inference
branch
3 times, most recently
from
22291a7 to
fd6c695
Compare
This was referenced Nov 15, 2023
jbrockmendel
force-pushed
the
enh-array_to_datetime-inference
branch
from
fd6c695 to
29854b7
Compare
jbrockmendel
force-pushed
the
enh-array_to_datetime-inference
branch
2 times, most recently
from
16acf25 to
51ce4a3
Compare
jbrockmendel
force-pushed
the
enh-array_to_datetime-inference
branch
2 times, most recently
from
f1ec518 to
905a1fc
Compare
jbrockmendel
force-pushed
the
enh-array_to_datetime-inference
branch
from
905a1fc to
6835800
Compare
This was referenced Nov 23, 2023
jbrockmendel
force-pushed
the
enh-array_to_datetime-inference
branch
4 times, most recently
from
9005743 to
be2866a
Compare
jbrockmendel
force-pushed
the
enh-array_to_datetime-inference
branch
3 times, most recently
from
12f19a2 to
b27f20a
Compare
|
@mroeschke thoughts on getting this across the finish line? |
|
/preview |
mroeschke
reviewed
May 22, 2024
|
|
||
| for res in [result6, result8, result9]: | ||
| # These cases go through array_to_datetime, not array_to_strptime. | ||
| # This means that as of GH#??? they do resolution inference |
There was a problem hiding this comment.
Is there an issue now for this?
There was a problem hiding this comment.
looks like this comment is out of date and all the cases now do inference. will update.
|
I had 2 comments otherwise looks OK. Do you think we can also do the same for timedelta before 3.0? |
Not likely. IIRC even the scalar case doesnt do inference on strings yet. |
mroeschke
approved these changes
May 31, 2024
|
Nice to finally get this in @jbrockmendel |
3 tasks
WillAyd
added a commit
to WillAyd/pandas
that referenced
this pull request
Aug 22, 2024
WillAyd
added a commit
to WillAyd/pandas
that referenced
this pull request
Aug 22, 2024
WillAyd
added a commit
to WillAyd/pandas
that referenced
this pull request
Aug 22, 2024
WillAyd
added a commit
to WillAyd/pandas
that referenced
this pull request
Aug 22, 2024
WillAyd
added a commit
to WillAyd/pandas
that referenced
this pull request
Aug 22, 2024
WillAyd
added a commit
to WillAyd/pandas
that referenced
this pull request
Aug 27, 2024
lithomas1
pushed a commit
to lithomas1/pandas
that referenced
this pull request
Sep 8, 2024
WillAyd
added a commit
to WillAyd/pandas
that referenced
this pull request
Sep 20, 2024
jorisvandenbossche
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Oct 2, 2024
jorisvandenbossche
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Oct 2, 2024
jorisvandenbossche
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Oct 3, 2024
jorisvandenbossche
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Oct 7, 2024
jorisvandenbossche
pushed a commit
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read_csvandto_datetime#54048doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This is an API change so will have to wait for 3.0, posting it to get feedback on desired API in mostly-IO places where this causes API changes.
This does not yet handle Timedelta scalar, TimedeltaIndex, or pd.to_timedelta. I'd like to get those done for 3.0 but its a much lower priority than the datetime side.
I've been splitting things off to reduce the diff, will try to keep doing that. Open to suggestions for splittable components. Currently #55741 has some of the cython implementation.
19 tests are failing locally. 11 of those are stata tests that would be addressed by #55642. 4 are SAS and have a similar option available. One is in JSON and may be hard to solve, xref #55827. The rest are caused by #55737.