-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assorted backports for 2.2.x #59785
Assorted backports for 2.2.x #59785
Conversation
* Remove deprecated plot_date calls These were deprecated in Matplotlib 3.9. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit c9bc480)
91225ea
to
1660c51
Compare
.github/workflows/unit-tests.yml
Outdated
@@ -257,7 +257,7 @@ jobs: | |||
. ~/virtualenvs/pandas-dev/bin/activate | |||
python -m pip install --no-cache-dir -U pip wheel setuptools meson[ninja]==1.2.1 meson-python==0.13.1 | |||
python -m pip install numpy --config-settings=setup-args="-Dallow-noblas=true" | |||
python -m pip install --no-cache-dir versioneer[toml] cython python-dateutil pytz pytest>=7.3.2 pytest-xdist>=2.2.0 hypothesis>=6.46.1 | |||
python -m pip install --no-cache-dir versioneer[toml] cython python-dateutil pytz<2024.2 pytest>=7.3.2 pytest-xdist>=2.2.0 hypothesis>=6.46.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pytz 2024.2 is causing a failure in test_array.py
(relating to constructing an array from datetime objects with pytz timezones)
I've pinned in testing for now.
I'm wondering if I should pin it as a dep too?
(as far as I can tell, all pytz did was update their IANA tzdb to 2024.2, so maybe this fixes itself when everyone else does too?)
On phone so sorry for not linking better, but I think the DTI failures need to be partially pulled from #55901. If you look at the commits in the 2.3 branch I started you will see a commit where I do that |
1660c51
to
679e45e
Compare
I think I have most of the relevant fixes picked from your PR, actually. Only headscratcher for me right now is the ARM build jobs (which also happen to fail on main). |
all green 🚀 |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.