Minor improvements to PosixFS
#17972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
added
the
category:internal
…ync`, and remove `PathStatGetter` (which had performance pitfalls, but was only used in tests anyway).
stuhood
force-pushed
the
stuhood/stat-sync-fixes
branch
from
06456fa
to
c007e9a
Compare
tdyas
approved these changes
Jan 11, 2023
jsirois
added a commit
to jsirois/pants
that referenced
this pull request
Jan 16, 2023
This reverts commit 4a0af5e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read_linkto avoid a spawnstat_syncis synchronousPathStatGetter(which had performance pitfalls, but was only used in tests anyway).