Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run platform-specific tests on GitHub-hosted macOS ARM runners #20997

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Run platform-specific tests on GitHub-hosted macOS ARM runners #20997

wants to merge 4 commits into from

Conversation

huonw
Copy link
Contributor

@huonw huonw commented Jun 4, 2024 •
edited
Loading

This (currently) uses the GitHub-hosted runner, as an experiment.

Fixes #20993

@huonw huonw added the category:internal CI, fixes for not-yet-released features, etc. label Jun 4, 2024
This was referenced Jun 4, 2024
Merged
Open
huonw added a commit that referenced this pull request Jun 4, 2024
@huonw
Update console and indicatif deps (#20998)
cc5577e 
These dependencies were using a git dependency due to unmerged
bug-fixes. These fixes have now been merged and are available in the
latest releases:

- console-rs/console#186
- console-rs/indicatif#608

In addition, I think the commits in question may've disappeared? E.g.
the fresh build on the new CI platform in had this error:
#20997

```
    Updating git repository `https://github.com/tgolsson/console.git`
error: failed to load source for dependency `console`

Caused by:
  Unable to update https://github.com/tgolsson/console.git?rev=5483880905f384679d322e83c37180f122951995#54838809

Caused by:
  revspec '5483880905f384679d322e83c37180f122951995' not found; class=Reference (4); code=NotFound (-3)
```

Thus, this is marked for cherry-picking back to our active branches.
WorkerPants pushed a commit that referenced this pull request Jun 4, 2024
@huonw @WorkerPants
Update console and indicatif deps (#20998)
50187a8 
These dependencies were using a git dependency due to unmerged
bug-fixes. These fixes have now been merged and are available in the
latest releases:

- console-rs/console#186
- console-rs/indicatif#608

In addition, I think the commits in question may've disappeared? E.g.
the fresh build on the new CI platform in had this error:
#20997

```
    Updating git repository `https://github.com/tgolsson/console.git`
error: failed to load source for dependency `console`

Caused by:
  Unable to update https://github.com/tgolsson/console.git?rev=5483880905f384679d322e83c37180f122951995#54838809

Caused by:
  revspec '5483880905f384679d322e83c37180f122951995' not found; class=Reference (4); code=NotFound (-3)
```

Thus, this is marked for cherry-picking back to our active branches.
WorkerPants pushed a commit that referenced this pull request Jun 4, 2024
@huonw @WorkerPants
Update console and indicatif deps (#20998)
38fcc03 
These dependencies were using a git dependency due to unmerged
bug-fixes. These fixes have now been merged and are available in the
latest releases:

- console-rs/console#186
- console-rs/indicatif#608

In addition, I think the commits in question may've disappeared? E.g.
the fresh build on the new CI platform in had this error:
#20997

```
    Updating git repository `https://github.com/tgolsson/console.git`
error: failed to load source for dependency `console`

Caused by:
  Unable to update https://github.com/tgolsson/console.git?rev=5483880905f384679d322e83c37180f122951995#54838809

Caused by:
  revspec '5483880905f384679d322e83c37180f122951995' not found; class=Reference (4); code=NotFound (-3)
```

Thus, this is marked for cherry-picking back to our active branches.
This was referenced Jun 4, 2024
Merged
Merged
@huonw huonw force-pushed the huonw/20993-psb-arm-ci branch from 1b979b1 to bfaa8f4 Compare June 4, 2024 22:06
@huonw huonw mentioned this pull request Jun 5, 2024
Merged
huonw added a commit that referenced this pull request Jun 5, 2024
@WorkerPants @huonw
Update console and indicatif deps (Cherry-pick of #20998) (#21001)
18f1bdd 
These dependencies were using a git dependency due to unmerged
bug-fixes. These fixes have now been merged and are available in the
latest releases:

- console-rs/console#186
- console-rs/indicatif#608

In addition, I think the commits in question may've disappeared? E.g.
the fresh build on the new CI platform in had this error:
#20997

```
    Updating git repository `https://github.com/tgolsson/console.git`
error: failed to load source for dependency `console`

Caused by:
  Unable to update https://github.com/tgolsson/console.git?rev=5483880905f384679d322e83c37180f122951995#54838809

Caused by:
  revspec '5483880905f384679d322e83c37180f122951995' not found; class=Reference (4); code=NotFound (-3)
```

Thus, this is marked for cherry-picking back to our active branches.

Co-authored-by: Huon Wilson <huon@exoflare.io>
huonw added a commit that referenced this pull request Jun 5, 2024
@WorkerPants @huonw
Update console and indicatif deps (Cherry-pick of #20998) (#21002)
170ed83 
These dependencies were using a git dependency due to unmerged
bug-fixes. These fixes have now been merged and are available in the
latest releases:

- console-rs/console#186
- console-rs/indicatif#608

In addition, I think the commits in question may've disappeared? E.g.
the fresh build on the new CI platform in had this error:
#20997

```
    Updating git repository `https://github.com/tgolsson/console.git`
error: failed to load source for dependency `console`

Caused by:
  Unable to update https://github.com/tgolsson/console.git?rev=5483880905f384679d322e83c37180f122951995#54838809

Caused by:
  revspec '5483880905f384679d322e83c37180f122951995' not found; class=Reference (4); code=NotFound (-3)
```

Thus, this is marked for cherry-picking back to our active branches.

Co-authored-by: Huon Wilson <huon@exoflare.io>
@huonw
Copy link
Contributor Author

huonw commented Jun 5, 2024

Looks like various tests fail. A quick skim suggests that these are ones parametrised by python version with the 3.7 & 3.8 versions failing. My memory is that 3.9 is the first version that works on ARM macOS reliably, so these tests probably don't make sense/need to be guarded off.

pants test src/python/pants/backend/codegen/protobuf/python/rules_integration_test.py:rules_integration_test src/python/pants/backend/python/goals/coverage_py_integration_test.py:tests src/python/pants/backend/python/goals/pytest_runner_integration_test.py:tests src/python/pants/backend/python/goals/repl_integration_test.py:tests src/python/pants/backend/python/lint/add_trailing_comma/rules_integration_test.py:tests src/python/pants/backend/python/lint/autoflake/rules_integration_test.py:tests src/python/pants/backend/python/lint/bandit/rules_integration_test.py:tests src/python/pants/backend/python/lint/black/rules_integration_test.py:tests src/python/pants/backend/python/lint/docformatter/rules_integration_test.py:tests src/python/pants/backend/python/lint/flake8/rules_integration_test.py:tests src/python/pants/backend/python/lint/isort/rules_integration_test.py:tests src/python/pants/backend/python/lint/pydocstyle/rules_integration_test.py:tests src/python/pants/backend/python/lint/pylint/rules_integration_test.py:tests src/python/pants/backend/python/lint/pyupgrade/rules_integration_test.py:tests src/python/pants/backend/python/lint/ruff/rules_integration_test.py:tests src/python/pants/backend/python/lint/yapf/rules_integration_test.py:tests src/python/pants/backend/python/typecheck/mypy/rules_integration_test.py:tests src/python/pants/backend/terraform/dependency_inference_test.py:dependency_inference_test
``

@huonw
Copy link
Contributor Author

huonw commented Aug 7, 2024 •
edited
Loading

Still failing now, even after #20998 and #21032 are in.

All failures seem to be errors about forbidden skipped tests due to Python 3.7 and 3.8 being missing.

src/python/pants/backend/python/lint/docformatter/rules_integration_test.py::test_passing[3.7] ERROR [ 33%]
src/python/pants/backend/python/lint/docformatter/rules_integration_test.py::test_passing[3.8] ERROR [ 66%]
src/python/pants/backend/python/lint/docformatter/rules_integration_test.py::test_passing[3.9] PASSED [100%]

==================================== ERRORS ====================================
_____________________ ERROR at setup of test_passing[3.7] ______________________
Forbidden skipped test - Skipped: Could not find python 3.7 on system. Skipping.
_____________________ ERROR at setup of test_passing[3.8] ______________________
Forbidden skipped test - Skipped: Could not find python 3.8 on system. Skipping.
- generated xml file: src.python.pants.backend.python.lint.docformatter.rules_integration_test.py.tests.xml -
=========================== short test summary info ============================
ERROR src/python/pants/backend/python/lint/docformatter/rules_integration_test.py::test_passing[3.7]
ERROR src/python/pants/backend/python/lint/docformatter/rules_integration_test.py::test_passing[3.8]
================== 1 passed, 4 deselected, 2 errors in 3.59s ===================

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run tests on MacOS ARM in CI
1 participant
@huonw