-
-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run clippy with nightly rust on CI #6347
Merged
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
ee76109
Remove calls to std::env::home_dir
illicitonion 7126602
Ensure temporary is kept alive while used
illicitonion 29a2e67
Split on char not string
illicitonion 6a043aa
Remove redundant returns
illicitonion 317b2b9
Don't clone things which are Copy
illicitonion 50fa388
Sleep in loop
illicitonion dd192fd
Take reference to slice
illicitonion 1acc911
Take reference
illicitonion a24a3e3
Use if instead of match or map
illicitonion f298015
Extract inline function
illicitonion 742c6e0
Take cheaper or value or reference
illicitonion 6fa34e4
Remove redundant into_iter()
illicitonion 9c6cb03
Use +=
illicitonion 925abd0
Invert ifs
illicitonion 7e89c61
Don't use useless format
illicitonion 546d818
Don't use _ for used variable
illicitonion 16181ac
Use closure, rather than unconditionally executing
illicitonion f4d2fc7
Add check for negative timeout
illicitonion 5822447
Enable clippy for all crates except bazel_protos
illicitonion 2620afa
CI runs clippy
illicitonion bc1cf56
Actually run clippy on CI
illicitonion 14a1a68
Install fuse
illicitonion File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lint shard is not one of the shortest... while it's a bit odd, I'd wonder whether it would make more sense to do this on the rust tests shard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was unsure between a new shard, the rust tests shard, and the lint shard...
The disadvantage of the test shard is that it conflates style issues with test issues, but I guess that's fine. I'm kind of tempted to just make it its own shard; there's very little set-up to do, now that we cache the rust toolchains...