Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell fmt parade #8

Merged
merged 3 commits into from
Aug 3, 2024
Merged

Cell fmt parade #8

merged 3 commits into from
Aug 3, 2024

Conversation

kysshsy
Copy link

@kysshsy kysshsy commented Jul 31, 2024

This pr:

  1. Fix bug in Cell type Bytea fmt function.
    1.1 Missing single quotes around the string \xABCD -> '\xABCD' (...)
    1.2 if bytes len is 0, it should be '' . '\x' -> ''.
  2. I found a bug before. It's because the different representation of hex in postgres and duckdb.
    duckdb hex: '\xAB\xCD'
    postgres hex: '\xABCD'
    It's not compatible. So ...I think it should implement postgres style in Wrapper repo. Duckdb style should be a user-defined function. And I implement trait CellFormatter allow to do that.
    This implementation is better than implementing the DuckDB pattern and more conducive to upstream.
    raise a PR : feat: Add user-defined cell fmt interface supabase/wrappers#316

@philippemnoel
Copy link

This pr:

  1. Fix bug in Cell type Bytea fmt function.
    1.1 Missing single quotes around the string \xABCD -> '\xABCD' (...)
    1.2 if bytes len is 0, it should be '' . '\x' -> ''.
  2. I found a bug before. It's because the different representation of hex in postgres and duckdb.
    duckdb hex: '\xAB\xCD'
    postgres hex: '\xABCD'
    It's not compatible. So ...I think it should implement postgres style in Wrapper repo. Duckdb style should be a user-defined function. And I implement trait CellFormatter allow to do that.
    This implementation is better than implementing the DuckDB pattern and more conducive to upstream.
    raise a PR : feat: Add user-defined cell fmt interface supabase/wrappers#316

Thank you for making this! We really should PR this repository upstream and just start using upstream...

@kysshsy kysshsy marked this pull request as ready for review August 2, 2024 11:45
@kysshsy kysshsy marked this pull request as draft August 2, 2024 14:48
@kysshsy kysshsy marked this pull request as ready for review August 2, 2024 14:49
@philippemnoel philippemnoel merged commit a76c2ee into paradedb:main Aug 3, 2024
1 check passed
Weijun-H pushed a commit to Weijun-H/wrappers that referenced this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants