feat: Add user-defined cell fmt interface #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@burmecia Hi, could you review my code or give some advice? |
|
That's great, thanks for the PR! Can you merge latest main branch so the CI can run success? |
updated. Thank you. I am pleased to make a contribution. |
|
seems CI fails... |
|
This pr is a part of #320 |
yep, did some CI refactoring and should be okay now. |
|
rebase and mark it as ready. :) @burmecia |
burmecia
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
What is the current behavior?
The Cell type format is fixed. While developing a PR for paradeb, I discovered that types like Bytea or Timestamp might be represented differently in various databases. The fmt function of Cell currently supports only the PostgreSQL style. It would be beneficial for users to define their own formatting function while retaining the qual deparse function.
Bytea in postgres is '\x68656C6C6F' and '\x68\x65\x6C\x6C\x6F' in duckdb. It's not Compatible. etc.
What is the new behavior?
Users of the crate could implement their own custom formatting for the Cell type
Additional context
paradedb pr: paradedb/paradedb#1404
postgres bytea hex fomat
duckdb bytea hex format