feat: display warning for op-mainnet launch without pre-Bedrock state #11765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevencartavia
requested review from
mattsse,
Rjected,
fgimenez,
emhane and
gakonst
as code owners
mattsse
requested changes
Oct 15, 2024
crates/optimism/chainspec/src/lib.rs
Outdated
Comment on lines
71
to
78
| let is_bedrock_active = OP_MAINNET.is_bedrock_active_at_block(105235063); | ||
|
|
||
| if !is_bedrock_active { | ||
| warn!( | ||
| "Warning: Op-mainnet has been launched without importing the pre-Bedrock state. \ | ||
| The chain will not progress without this import. \ | ||
| Please ensure that the pre-Bedrock state is imported to avoid synchronization issues and ensure proper chain operation." | ||
| ); |
There was a problem hiding this comment.
this isn't quite right, because the chainspec only tracks static activation.
but we need checks this against the local database when the chain is op-mainnet
I believe the best location to do this would be somewhere here
reth/crates/node/builder/src/launch/common.rs
Line 829 in 78415ff
we could introduce a helper function that is something like
fn chain_specific_db_checks
which would only check if the chain id is op-mainnet for example
wdyt @joshieDo
There was a problem hiding this comment.
yeah i think it could work
joshieDo
reviewed
Oct 29, 2024
crates/node/builder/src/lib.rs
Outdated
| @@ -5,7 +5,6 @@ | |||
| html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256", | |||
| issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/" | |||
| )] | |||
| #![cfg_attr(not(test), warn(unused_crate_dependencies))] | |||
joshieDo
reviewed
Oct 29, 2024
| chain_spec.fork(OptimismHardfork::Bedrock).active_at_block(105235063); | ||
|
|
||
| if db_checks_passed && !is_bedrock_active { | ||
| warn!("Op-mainnet has been launched without importing the pre-Bedrock state. The chain won't progress without this."); |
There was a problem hiding this comment.
We should just error if we dont pass the check
joshieDo
reviewed
Oct 29, 2024
joshieDo
reviewed
Oct 29, 2024
mattsse
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11632