-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display warning for op-mainnet launch without pre-Bedrock state #11765
Merged
mattsse
merged 12 commits into
paradigmxyz:main
from
stevencartavia:feat/op-mainnet-pre-bedrock-warning
Nov 14, 2024
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3e9dc2e
feat: display warning for op-mainnet launch without pre-Bedrock state
stevencartavia 14703a9
Merge branch 'main' into feat/op-mainnet-pre-bedrock-warning
stevencartavia 278924b
Merge branch 'main' into feat/op-mainnet-pre-bedrock-warning
stevencartavia 79ab2b3
update
stevencartavia 08602ee
update
stevencartavia 428f7e1
Merge branch 'main' into feat/op-mainnet-pre-bedrock-warning
stevencartavia 98545bd
clippy
stevencartavia d04edfe
fix
stevencartavia 2abf0a2
add bedrock check
mattsse ccf7498
Merge branch 'main' into feat/op-mainnet-pre-bedrock-warning
mattsse 15c20b4
add clippy
mattsse 6e5ac51
add link
mattsse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't quite right, because the chainspec only tracks static activation.
but we need checks this against the local database when the chain is op-mainnet
I believe the best location to do this would be somewhere here
reth/crates/node/builder/src/launch/common.rs
Line 829 in 78415ff
we could introduce a helper function that is something like
which would only check if the chain id is op-mainnet for example
wdyt @joshieDo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah i think it could work