Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(discv5): warning discv5 config socket override #12636

Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix(discv5): warning discv5 config socket override #12636

merged 1 commit into from
Nov 18, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Nov 18, 2024

Bug: warning is logged when same discv5 and rlpx address are used.

Fix: check if rlpx address and discv5 address are equal, if discv5 address is set.

@emhane emhane added C-bug An unexpected or incorrect behavior A-observability Related to tracing, metrics, logs and other observability tools A-discv5 Related to discv5 discovery labels Nov 18, 2024
@emhane emhane requested a review from joshieDo November 18, 2024 15:36
mattsse
mattsse approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool,
can confirm it removes the warning

@mattsse mattsse added this pull request to the merge queue Nov 18, 2024
Merged via the queue into main with commit 55b5136 Nov 18, 2024
41 checks passed
@mattsse mattsse deleted the emhane/discv5-args-config branch November 18, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@joshieDo joshieDo Awaiting requested review from joshieDo

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-discv5 Related to discv5 discovery A-observability Related to tracing, metrics, logs and other observability tools C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @mattsse