Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(discv5): warning discv5 config socket override #12636

Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix(discv5): warning discv5 config socket override #12636

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions crates/net/discv5/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,11 +412,13 @@ pub fn discv5_sockets_wrt_rlpx_addr(
discv5_addr_ipv6.map(|ip| SocketAddrV6::new(ip, discv5_port_ipv6, 0, 0));

if let Some(discv5_addr) = discv5_addr_ipv4 {
warn!(target: "net::discv5",
%discv5_addr,
%rlpx_addr,
"Overwriting discv5 IPv4 address with RLPx IPv4 address, limited to one advertised IP address per IP version"
);
if discv5_addr != rlpx_addr {
warn!(target: "net::discv5",
%discv5_addr,
%rlpx_addr,
"Overwriting discv5 IPv4 address with RLPx IPv4 address, limited to one advertised IP address per IP version"
);
}
}

// overwrite discv5 ipv4 addr with RLPx address. this is since there is no
Expand All @@ -429,11 +431,13 @@ pub fn discv5_sockets_wrt_rlpx_addr(
discv5_addr_ipv4.map(|ip| SocketAddrV4::new(ip, discv5_port_ipv4));

if let Some(discv5_addr) = discv5_addr_ipv6 {
warn!(target: "net::discv5",
%discv5_addr,
%rlpx_addr,
"Overwriting discv5 IPv6 address with RLPx IPv6 address, limited to one advertised IP address per IP version"
);
if discv5_addr != rlpx_addr {
warn!(target: "net::discv5",
%discv5_addr,
%rlpx_addr,
"Overwriting discv5 IPv6 address with RLPx IPv6 address, limited to one advertised IP address per IP version"
);
}
}

// overwrite discv5 ipv6 addr with RLPx address. this is since there is no
Expand Down
Loading