feat(db): initialize db with tables

[alessandromazza98]

Supersedes #13125 (review)

@mattsse

[mattsse]

this can just return Boxed iter of Table instead, no need for the associated type

[alessandromazza98]

you mean directly using Box<dyn Iterator<Item = Box<dyn TableMetadata>>> as return type for the tables function and remove the TableIter associated type?

[alessandromazza98]

or it could be like this:

pub trait TableSet {
    /// Returns an iterator over the tables
    fn tables() -> Box<dyn Iterator<Item = Box<dyn TableMetadata>>>;
}

and then the impl inside the tables! macro:

impl TableSet for Tables {
    fn tables() -> Box<dyn Iterator<Item = Box<dyn TableMetadata>>> {
        Box::new(Self::ALL.iter().map(|table| Box::new(*table) as Box<dyn TableMetadata>))
    }
}

[mattsse]

some suggestions

[mattsse]

lgtm

next step would be repeating the same thing for functions that call create_tables, like

https://github.com/paradigmxyz/reth/blob/main/crates/storage/db/src/mdbx.rs#L31-L39

essentially walking up the call graph

[alessandromazza98]

lgtm

next step would be repeating the same thing for functions that call create_tables, like

https://github.com/paradigmxyz/reth/blob/main/crates/storage/db/src/mdbx.rs#L31-L39

essentially walking up the call graph

great, im gonna work on it