-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): custom tables #7832
Conversation
4ba1af4
to
920c123
Compare
920c123
to
e932abe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, what's your use case for this? adding new tables to the existing DB?
we don't really want to open this up becomes then it becomes harder to transition to a new db in the future
The use case is to use crate If this is not the intended use of |
reopening this, because this is still something we want to support and this is likely useful as a reference FYI @onbjerg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm closing this now that we have a path forward here
ref #13130
Awesome! I'll take a look at new approach |
not quite there yet, but almost |
Addresses #4546
This is a first draft how to support custom tables. Any feedback highly appreciated (or if this approach is not good and some other is preffered)
Example in the action: