Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): custom tables #7832

Closed
wants to merge 1 commit into from

Conversation

Vid201
Copy link
Contributor

@Vid201 Vid201 commented Apr 23, 2024

Addresses #4546

This is a first draft how to support custom tables. Any feedback highly appreciated (or if this approach is not good and some other is preffered)

Example in the action:

@Vid201 Vid201 force-pushed the feat/db_custom_tables branch from 4ba1af4 to 920c123 Compare April 25, 2024 19:38
@Vid201 Vid201 force-pushed the feat/db_custom_tables branch from 920c123 to e932abe Compare April 25, 2024 19:41
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, what's your use case for this? adding new tables to the existing DB?

we don't really want to open this up becomes then it becomes harder to transition to a new db in the future

@Vid201
Copy link
Contributor Author

Vid201 commented Apr 26, 2024

hmm, what's your use case for this? adding new tables to the existing DB?

we don't really want to open this up becomes then it becomes harder to transition to a new db in the future

The use case is to use crate reth_db for database in our project. But we are not using the same tables as reth node, but we have some custom tables (https://github.com/silius-rs/silius/blob/chore/reth_db/crates/mempool/src/database/tables.rs)

If this is not the intended use of reth_db, no problem, we'll use something else

@emhane emhane added C-enhancement New feature or request A-db Related to the database labels May 16, 2024
@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Jul 10, 2024
@github-actions github-actions bot closed this Jul 26, 2024
@mattsse
Copy link
Collaborator

mattsse commented Jul 26, 2024

reopening this, because this is still something we want to support and this is likely useful as a reference FYI @onbjerg

@mattsse mattsse reopened this Jul 26, 2024
@mattsse mattsse added M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity and removed S-stale This issue/PR is stale and will close with no further activity labels Jul 26, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm closing this now that we have a path forward here

ref #13130

@mattsse mattsse closed this Dec 6, 2024
@Vid201
Copy link
Contributor Author

Vid201 commented Dec 6, 2024

I'm closing this now that we have a path forward here

ref #13130

Awesome! I'll take a look at new approach

@mattsse
Copy link
Collaborator

mattsse commented Dec 7, 2024

not quite there yet, but almost

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-db Related to the database C-enhancement New feature or request M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants