Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add getBlockReceipts #3321

Merged
merged 5 commits into from
Jun 26, 2023
Merged

feat: add getBlockReceipts #3321

merged 5 commits into from
Jun 26, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jun 22, 2023

closes #3305

blocked by #3320

adds eth_getBlockReceipts impl
reuses existing convert functions

@mattsse mattsse added S-blocked This cannot more forward until something else changes A-rpc Related to the RPC implementation labels Jun 22, 2023
@onbjerg onbjerg added the C-enhancement New feature or request label Jun 26, 2023
@mattsse mattsse removed the S-blocked This cannot more forward until something else changes label Jun 26, 2023
@mattsse mattsse requested a review from onbjerg June 26, 2023 19:24
@mattsse mattsse marked this pull request as ready for review June 26, 2023 19:24
@mattsse mattsse requested a review from Rjected as a code owner June 26, 2023 19:24
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #3321 (09bddc4) into main (007c04e) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3321      +/-   ##
==========================================
- Coverage   69.26%   69.21%   -0.06%     
==========================================
  Files         537      537              
  Lines       72088    72142      +54     
==========================================
+ Hits        49931    49932       +1     
- Misses      22157    22210      +53     
Flag Coverage Δ
integration-tests 16.29% <0.00%> (-0.01%) ⬇️
unit-tests 64.29% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bin/reth/src/args/rpc_server_args.rs 47.09% <0.00%> (-0.27%) ⬇️
crates/rpc/rpc-api/src/eth.rs 100.00% <ø> (ø)
crates/rpc/rpc/src/eth/api/block.rs 52.83% <0.00%> (-27.17%) ⬇️
crates/rpc/rpc/src/eth/api/server.rs 93.82% <0.00%> (-1.59%) ⬇️
crates/rpc/rpc/src/eth/api/transactions.rs 26.19% <0.00%> (-0.41%) ⬇️
crates/rpc/rpc/src/eth/cache.rs 64.28% <0.00%> (-2.26%) ⬇️
crates/rpc/rpc/src/eth/filter.rs 17.73% <0.00%> (+0.48%) ⬆️

... and 7 files with indirect coverage changes

@onbjerg onbjerg added the M-changelog This change should be included in the changelog label Jun 26, 2023
@mattsse mattsse enabled auto-merge June 26, 2023 19:47
@mattsse mattsse added this pull request to the merge queue Jun 26, 2023
Merged via the queue into main with commit 9721ecf Jun 26, 2023
26 checks passed
@mattsse mattsse deleted the matt/add-block-receipts branch June 26, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request M-changelog This change should be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add eth_getBlockReceipts
2 participants