Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pending block with receipts #3404

Merged
merged 3 commits into from
Jun 26, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jun 26, 2023

Adds another function to unblock #3321

we need to fetch this one go, because this is susceptible to a race and hence block + receipts can't be fetched in two separate calls using the existing methods

@mattsse mattsse added C-enhancement New feature or request A-rpc Related to the RPC implementation labels Jun 26, 2023
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, although I would like a note in the docs on the potential race condition so it is documented

@mattsse mattsse enabled auto-merge June 26, 2023 16:32
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #3404 (669509b) into main (49922bf) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3404      +/-   ##
==========================================
- Coverage   69.41%   69.29%   -0.13%     
==========================================
  Files         537      537              
  Lines       71991    72058      +67     
==========================================
- Hits        49973    49933      -40     
- Misses      22018    22125     +107     
Flag Coverage Δ
integration-tests 16.30% <0.00%> (-0.04%) ⬇️
unit-tests 64.37% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/blockchain-tree/src/shareable.rs 40.51% <0.00%> (-2.22%) ⬇️
crates/interfaces/src/blockchain_tree/mod.rs 31.57% <ø> (ø)
...tes/storage/provider/src/providers/database/mod.rs 24.47% <0.00%> (-0.32%) ⬇️
...torage/provider/src/providers/database/provider.rs 74.22% <0.00%> (-0.19%) ⬇️
crates/storage/provider/src/providers/mod.rs 8.56% <0.00%> (-0.13%) ⬇️
crates/storage/provider/src/test_utils/mock.rs 23.94% <0.00%> (-1.91%) ⬇️
crates/storage/provider/src/test_utils/noop.rs 22.17% <0.00%> (-4.26%) ⬇️
crates/storage/provider/src/traits/block.rs 30.76% <ø> (ø)

... and 33 files with indirect coverage changes

@mattsse mattsse added this pull request to the merge queue Jun 26, 2023
Merged via the queue into main with commit 112313e Jun 26, 2023
@mattsse mattsse deleted the matt/more-helper-provider-functions branch June 26, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants