Added exhaustiveness check to src/ir/AST/Util.hs
#145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes issues #138 and #139, which were caused by missing cases in the utility functions for AST. This commit also makes GHC produce an error if a new AST node is added without the proper cases in `Util.hs`, preventing these kinds of mistakes again. To make this work there can be no "catch all" cases in the functions `getChildren` and `putChildren`. This inconvenience is outweighed by the fact that we are guaranteed to never forget adding a case for our new AST nodes.
This commit fixes issues #138 and #139, which were caused by missing cases in the utility functions for AST. This commit also makes GHC produce an error if a new AST node is added without the proper cases in `Util.hs`, preventing these kinds of mistakes again. To make this work there can be no "catch all" cases in the functions `getChildren` and `putChildren`. This inconvenience is outweighed by the fact that we are guaranteed to never forget adding a case for our new AST nodes.
|
Hi there, I was wondering why do you have 3 commits, when 2 of them seem to be the same and the last is not relevant to the PR. I believe you are working on your master branch in your fork. Whenever you pull from upstream and push to origin (your fork), the PR gets those changes as well. In order to solve this, create a new branch and put the commit that you want to create as PR. Push to origin and create the PR again. I don't think there's an easy way to refactor this, since it's linked to your master's fork. |
|
You are very right, I tried rebasing upstream after submitting the pull request. Will redo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes issues #138 and #139, which were caused by missing
cases in the utility functions for AST. This commit also makes GHC
produce an error if a new AST node is added without the proper cases in
Util.hs, preventing these kinds of mistakes again. To make this workthere can be no "catch all" cases in the functions
getChildrenandputChildren. This inconvenience is outweighed by the fact that we areguaranteed to never forget adding a case for our new AST nodes.
I borrowed the test case from @kikofernandez earlier pull request (that I rejected).