Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added exhaustiveness check to src/ir/AST/Util.hs #145

Closed
wants to merge 3 commits into from
Closed

Added exhaustiveness check to src/ir/AST/Util.hs #145

wants to merge 3 commits into from

Commits on Apr 27, 2015

  1. Added exhaustiveness check to src/ir/AST/Util.hs 

    This commit fixes issues #138 and #139, which were caused by missing
cases in the utility functions for AST. This commit also makes GHC
produce an error if a new AST node is added without the proper cases in
`Util.hs`, preventing these kinds of mistakes again. To make this work
there can be no "catch all" cases in the functions `getChildren` and
`putChildren`. This inconvenience is outweighed by the fact that we are
guaranteed to never forget adding a case for our new AST nodes.
    @EliasC
    EliasC committed Apr 27, 2015
    Configuration menu
    Copy the full SHA
    dbcabf4 View commit details
    Browse the repository at this point in the history

  2. Added exhaustiveness check to src/ir/AST/Util.hs 

    This commit fixes issues #138 and #139, which were caused by missing
cases in the utility functions for AST. This commit also makes GHC
produce an error if a new AST node is added without the proper cases in
`Util.hs`, preventing these kinds of mistakes again. To make this work
there can be no "catch all" cases in the functions `getChildren` and
`putChildren`. This inconvenience is outweighed by the fact that we are
guaranteed to never forget adding a case for our new AST nodes.
    @EliasC
    EliasC committed Apr 27, 2015
    Configuration menu
    Copy the full SHA
    71b6283 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of https://github.com/EliasC/encore

    @EliasC
    EliasC committed Apr 27, 2015
    Configuration menu
    Copy the full SHA
    9d6803c View commit details
    Browse the repository at this point in the history