Remove addDependencyTo from parcel-bundler #2166
Conversation
| @@ -38,15 +38,7 @@ async function getConfig(asset) { | |||
| config = config || {}; | |||
| const plugins = config.plugins; | |||
| if (typeof plugins === 'object') { | |||
There was a problem hiding this comment.
Without depConfig, this conditional is redundant and should be removed.
There was a problem hiding this comment.
Should I drop the condition and call Object.keys(plugins).forEach(p => plugins[p]); directly?
There was a problem hiding this comment.
I suppose it would make sense to assume plugins is always an object.
There was a problem hiding this comment.
Should I... call
Object.keys(plugins).forEach(p => plugins[p])directly?
To do what? Without the Object.assign, it's not doing anything (apart from burning cycles).
There was a problem hiding this comment.
Sorry for the delayed response. Just to clarify, I should pull out the condition and the iteration of the plugins completely, right?
There was a problem hiding this comment.
Okay, I've pushed up an update. Thanks for the quick turnaround!
This fixes a persistent warning message when using `posthtml-include`. It's been about 10 months since `posthtml-loader` version `1.0.1` was released, and the warning makes it difficult to use Parcel. Fixes #1920
This was based on @chocolateboy's feedback in my PR.
|
@chocolateboy I wanted to give a gentle bump on this. Have you had a chance to look at the updates? |
|
@LandonSchropp Yes, it looks fine. I can't vouch for the removed test, though, and GitHub doesn't appear to provide a way for me to resolve/remove my obsolete feedback. |
|
@chocolateboy Any advice on what we need to do to get this guy merged? Is there anything else I should change? Should we ask somebody else to review for that test? |
|
I'm closing this PR. It looks like it's not going to get merged. |
|
@chocolateboy Was there anything blocking this from being merged? Not seeing all these messages would be a huge QOL improvement. |
↪️ Pull Request
Hi there! This issue was bugging me, so I thought I'd take a quick stab at fixing it. I'm not familiar with the Parcel codebase, and I might have missed something, so please let me know if this isn't the right way to go about this, or you're not interested in this fix at this time.
This fixes a persistent warning message when using
posthtml-include. It's been about 10 months sinceposthtml-loaderversion1.0.1was released, and the warning makes it difficult to use Parcel.Fixes #1920
💻 Examples
Here's an example of my project's build after adding and removing whitespace three times:
🚨 Test instructions
The easiest way to test is to add an
<include name="template"></include>to an HTML file.✔️ PR Todo