Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy posthtml-include support (addDependencyTo) #2966

Closed
wants to merge 1 commit into from
Closed

Remove legacy posthtml-include support (addDependencyTo) #2966

wants to merge 1 commit into from

Conversation

christianscott
Copy link

↪️ Pull Request

Reopening #2166 on behalf of @LandonSchropp (I asked if it was OK 🙂).

Only difference is I didn't remove the test case, which seems to pass just fine.

💻 Examples

See #2166.

🚨 Test instructions

See #2166.

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@DeMoorJasper
Copy link
Member

This is a breaking change and will likely not get merged in Parcel 1. Would be great to get this in Parcel 2 once it has a html transformer

Sent with GitHawk

@wbinnssmith wbinnssmith mentioned this pull request May 21, 2019
3 tasks
@devongovett
Copy link
Member

Appears that this was covered in Parcel 2 by #3063.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants