This repository has been archived by the owner on Feb 26, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 67
Download network dapps and load them from filesystem #144
Merged
Merged
Changes from 9 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
0af589d
Download network (registry) dapps and load them from filesystem
axelchalon ecb4e93
Remove obsolete Rust files
axelchalon 5ef03f3
package-lock.json
axelchalon cd1a5e9
Linting
axelchalon 8452e2f
Fix tests
axelchalon a2cc6f0
Lint
axelchalon a76cfef
Fix .includes() is not a function (:88)
axelchalon 943765d
Remove rust files from CI build
axelchalon f76f89c
Update @parity/ui dependency
axelchalon 24f68a7
Grumbles
axelchalon 90ce81b
Restrict in-frame navigation for dapps (#146)
axelchalon 51ffdac
Grumbles
axelchalon 2d96027
Merge from master
axelchalon 3db6aa7
fs-extra pathExists doesn't throw if the path doesn't exist
axelchalon 532df40
Fix bug uglifyjs
amaury1093 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,7 @@ npm-debug.log | |
build | ||
dist | ||
docs | ||
test/tmp | ||
.build | ||
.coverage | ||
.dist | ||
|
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nodeintegration is enabled for the BrowserWindow but disabled by default for its WebWorkers; I had to add this option to remove the following error (wasn't blocking though):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fine, we are not requiring any external files as web workers.
Is the error stack longer? Who is requiring
@parity/shared/lib/webWorker.js
? I'd be more enthusiast to remove web workers altoghether.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's the whole error stack
we import some files of
@parity/shared
(for exampleimport { initStore } from '@parity/shared/lib/redux'
inindex.parity.js
) that require theworker
of@parity/shared
(in that case,initStore
callssetupWorker
). I imagine that's where it's coming from