This repository has been archived by the owner on Feb 26, 2020. It is now read-only.
Restrict in-frame navigation for dapps #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaury1093
reviewed
Jul 2, 2018
electron/index.js
Outdated
| @@ -18,6 +18,7 @@ const electron = require('electron'); | |||
| const fs = require('fs'); | |||
| const path = require('path'); | |||
| const url = require('url'); | |||
| const { URL, URLSearchParams } = url; | |||
There was a problem hiding this comment.
const { format, URL, URLSearchParams} = require('url'), or put this line under all the requires.
The linter doesn't yell here, but I think it's one of the rules to first import then const ..., so let's apply it here too.
The dapp could then display files from the filesystem in the same frame (incl. other dapps) This could be an attack vector: if good dapp was compromised and redirects the user to the filesystem location of a malicious network dapp (already fetched), then electron would pass the appId of good dapp to the malicious dapp, and malicious dapp would have the permissions of good dapp |
amaury1093
approved these changes
Jul 3, 2018
amaury1093
added
A8-looksgood
axelchalon
added a commit
that referenced
this pull request
Jul 3, 2018
* Restrict in-frame navigation for dapps * Lint
amaury1093
pushed a commit
that referenced
this pull request
Jul 9, 2018
* Download network (registry) dapps and load them from filesystem * Remove obsolete Rust files * package-lock.json * Linting * Fix tests * Lint * Fix .includes() is not a function (:88) * Remove rust files from CI build * Update @parity/ui dependency * Grumbles * Restrict in-frame navigation for dapps (#146) * Restrict in-frame navigation for dapps * Lint * Grumbles * fs-extra pathExists doesn't throw if the path doesn't exist * Fix bug uglifyjs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #118
?appIdwhen navigating to other files of the dapp (allows multi-page dapps to use the api; prevent appId spoofing)