[xcm ] Compatibility fix for xcm benchmarks

[bkontur]

There was a change on polkadot repo pallet_xcm benchmarks: https://github.com/paritytech/polkadot/pull/7077/files#diff-a4111c7c81a2c886c9cb40df80da8016448148fc24ba109150da006ebad5fcc6R134-R165
which moved initiate_reserve_withdraw/reserve_asset_deposited from pallet_xcm_benchmarks_generic.rs to file pallet_xcm_benchmarks_fungible.rs

and because CI for companions does not regenerate weights, there was no companion for that, so this PR fixes that

now after weights regeneration there is a compilation error: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3250422

Partially also fixes: paritytech/polkadot-sdk#1132

[bkontur]

bot help

[bkontur]

bot bench cumulus-assets --xcm=pallet_xcm_benchmarks::fungible
bot bench cumulus-assets --xcm=pallet_xcm_benchmarks::generic

[bkontur]

bot bench $ xcm cumulus-assets --pallet=pallet_xcm_benchmarks::fungible

[bkontur]

bot bench cumulus-assets --subcommand=xcm --pallet=pallet_xcm_benchmarks::fungible
bot bench cumulus-assets --subcommand=xcm --pallet=pallet_xcm_benchmarks::generic

[bkontur]

bot bench cumulus-bridge-hubs --subcommand=xcm --pallet=pallet_xcm_benchmarks::fungible
bot bench cumulus-bridge-hubs --subcommand=xcm --pallet=pallet_xcm_benchmarks::generic

[bkontur]

bot bench cumulus-assets --subcommand=xcm --pallet=pallet_xcm_benchmarks::fungible --runtime=asset-hub-kusama
bot bench cumulus-assets --subcommand=xcm --pallet=pallet_xcm_benchmarks::generic --runtime=asset-hub-kusama
bot bench cumulus-assets --subcommand=xcm --pallet=pallet_xcm_benchmarks::fungible --runtime=asset-hub-westend
bot bench cumulus-assets --subcommand=xcm --pallet=pallet_xcm_benchmarks::generic --runtime=asset-hub-westend
bot bench cumulus-bridge-hubs --subcommand=xcm --pallet=pallet_xcm_benchmarks::fungible --runtime=bridge-hub-kusama
bot bench cumulus-bridge-hubs --subcommand=xcm --pallet=pallet_xcm_benchmarks::generic --runtime=bridge-hub-kusama
bot bench cumulus-bridge-hubs --subcommand=xcm --pallet=pallet_xcm_benchmarks::fungible --runtime=bridge-hub-rococo
bot bench cumulus-bridge-hubs --subcommand=xcm --pallet=pallet_xcm_benchmarks::generic --runtime=bridge-hub-rococo

[gilescope]

It's not going to fit in a block at that size. If we want to prohibit it then we should be using max weight.

[bkontur]

probably thats the point, not to allow process reserve_asset_deposited by default,
this number was generated by:

let (trusted_reserve, transferable_reserve_asset) = T::TrustedReserve::get()
			.ok_or(BenchmarkError::Override(
				BenchmarkResult::from_weight(T::BlockWeights::get().max_block)
			))?;

and for AssetHubs where we allow IsReserve for transfer over bridge, this will have correct value in this branch: #2762

[bkontur]

@franciscoaguirre wdyt? you added reserve_asset_deposited benchmark :)

[bkontur]

before all this,
we had there hard-coded:

// TODO: hardcoded - fix https://github.com/paritytech/cumulus/issues/1974
		Weight::from_parts(1_000_000_000_u64, 0)

which is also not good

[bkontur]

@gilescope @franciscoaguirre
so the question is,
if it is better to change:

BenchmarkResult::from_weight(T::BlockWeights::get().max_block)

to:

BenchmarkResult::from_weight(Weight::MAX)

[gilescope]

rather than T::BlockWeights::get().max_block it's traditional to use Weight::MAX as that's the value we use everywhere else to mean not allowed.

[bkontur]

ok, I will fix that for pallet_xcm with Weight::MAX and use this PR as Companion

[bkontur]

ok, we cannot go with Weight:MAX now because: paritytech/polkadot#7546 (comment) because it breaks pallet_xcm::reserve_transfer_assets,
so I reverted back that hard-coded 1_000_000_000_u64,
anyway the result of this PR is that regeneration of weights will work in master again

but as a follow-up we need to fix and finish remote weight estimation (maybe with "standard xcm weights") plus:
paritytech/polkadot#7424
paritytech/polkadot#7546

[bkontur]

bot clean

[bkontur]

bot bench cumulus-assets --subcommand=xcm --pallet=pallet_xcm_benchmarks::fungible --runtime=asset-hub-kusama

[command-bot]

@bkontur https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3264556 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=asset-hub-kusama --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_benchmarks::fungible. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 21-bfe53269-df56-4b37-82e7-5191d76ee860 to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot]

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=asset-hub-kusama --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_benchmarks::fungible has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3264556 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3264556/artifacts/download.

[bkontur]

bot merge