Sniff the first byte to glean if the incoming request is a single or batch request #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…batch request This works around the serde limitations around `untagged` enums and `RawValue`.
dvdplm
commented
Jul 15, 2021
niklasad1
reviewed
Jul 15, 2021
niklasad1
reviewed
Jul 15, 2021
maciejhirsz
approved these changes
Aug 12, 2021
niklasad1
reviewed
Aug 12, 2021
| Err(_) => (Id::Null, JsonRpcErrorCode::ParseError), | ||
| }; | ||
| send_error(id, &tx, code.into()); | ||
| // Bacth of requests or notifications |
There was a problem hiding this comment.
Suggested change
| // Bacth of requests or notifications | |
| // Batch of requests or notifications |
niklasad1
reviewed
Aug 12, 2021
| /// Figure out if this is a sufficiently complete request that we can extract an [`Id`] out of, or just plain | ||
| /// unparseable garbage. | ||
| pub fn prepare_error(data: &[u8]) -> (Id<'_>, JsonRpcErrorCode) { | ||
| match serde_json::from_slice::<JsonRpcInvalidRequest>(&data) { |
There was a problem hiding this comment.
Suggested change
| match serde_json::from_slice::<JsonRpcInvalidRequest>(&data) { | |
| match serde_json::from_slice::<JsonRpcInvalidRequest>(data) { |
niklasad1
approved these changes
Aug 12, 2021
I did not run the benchmarks tbh. I should have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around the serde limitations around
untaggedenums andRawValueby instead looking at the first byte of the request: if it's a[then it's a batch request; if it's a{then it's a single request.The http case is less nice because there we have notifications (i.e. requests without an id, requiring no response).
Also see #420 as an alternative to this.
Closes #296