Don't allocate until we know it's worth it #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…batch request This works around the serde limitations around `untagged` enums and `RawValue`.
Also, rework the way we return errors: prefer JSON-RPC errors according to spec (application/json) wherever sensible.
dvdplm
commented
Aug 12, 2021
utils/src/hyper_helpers.rs
Outdated
| /// Returns `Err` if the body was too large or the body couldn't be read. | ||
| pub async fn read_response_to_body( | ||
| pub async fn read_body( |
There was a problem hiding this comment.
The relevant changes are in this function.
dvdplm
commented
Aug 12, 2021
| return Ok::<_, HyperError>(response::too_large("The request was too large")) | ||
| } | ||
|
|
||
| let (body, mut is_single) = match read_body(&parts.headers, body, max_request_body_size).await { |
There was a problem hiding this comment.
This is the relevant change of the PR.
maciejhirsz
approved these changes
Aug 12, 2021
niklasad1
reviewed
Aug 12, 2021
niklasad1
reviewed
Aug 12, 2021
niklasad1
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For http server, check first byte before allocating space for the body.
Also re-work error handling and prefer sending JSON-RPC-style errors (JSON doc, spec'd error codes) combined with http status codes.
Alternative to #419
Closes #296