types: make subscription ID String Cow. #594
Conversation
| impl<'a> SubscriptionId<'a> { | ||
| /// Convert `SubscriptionId<'a>` to `SubscriptionId<'static>` so that it can be moved across threads. | ||
| /// | ||
| /// This can cause an allocation if the id is a string. |
There was a problem hiding this comment.
technically only if s is a str slice.
| } | ||
|
|
||
| impl<'a> TryFrom<JsonValue> for SubscriptionId<'a> { | ||
| type Error = (); |
There was a problem hiding this comment.
Would there be any use in making this more specific so that we can catch the "wrong value type" vs "value too large" errors below?
|
Offhand it looks like we just use |
|
A bit of motivation for this change would be good, the code looks fine but I'm not sure why we need this. |
Yeah, it's compat stuff for other libraries (e.g. jsonrpc crate) but not sure if we need anymore so maybe better just to use |
Yeah you are correct, I didn't manage to get rid of however, this is not useful without further refactoring I guess besides to |
No description provided.