uint: bump version to 0.7 #136
Conversation
ethereum-types/Cargo.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "ethereum-types" | |||
| version = "0.5.0" | |||
| version = "0.5.1" | |||
There was a problem hiding this comment.
So the policy for dependent crates is to bump the the patch when updating a dependency?
There was a problem hiding this comment.
I don't think we have a hard policy on that but I think it's a good practise if applied sensibly? Do you see any downsides?
There was a problem hiding this comment.
Seems fine to me - was just curious what our convention was
There was a problem hiding this comment.
I think that depends on whether the change is breaking, I don't think it is for ethereum-types and primitive-types, but please correct me if I'm wrong.
There was a problem hiding this comment.
Or if you mean in general, I don't think we should do this in every case, but I'd like to publish new version of primitive-types as well.
There was a problem hiding this comment.
Yes of course my original comment is poorly phrased. Just when I've updated a dependency like this in the past (non breaking minor version) I was unsure about the correct bump for the parent crate.
There was a problem hiding this comment.
@sorpaas it seems like latest versions of ethereum-types were published from primitives repo. Can you confirm if that's correct? What's the purpose of ethereum-types in parity-common if so?
to incorporate #126