Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uint: bump version to 0.7 #136

Merged
merged 6 commits into from
May 11, 2019
Merged

uint: bump version to 0.7 #136

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7bff30c
uint: bump version to 0.7
ordian May 8, 2019
fa00fd6
primitive-types: bump version to 0.2.3
ordian May 8, 2019
8aac18a
ethereum-types: bump version to 0.5.1
ordian May 8, 2019
198199f
ethereum-types: bump to 0.5.3-beta.1
ordian May 8, 2019
f38f540
uint: update README.md for 0.7
ordian May 10, 2019
d4d4fab
uint: make benches compile
ordian May 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ethereum-types/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "ethereum-types"
version = "0.5.0"
version = "0.5.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the policy for dependent crates is to bump the the patch when updating a dependency?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have a hard policy on that but I think it's a good practise if applied sensibly? Do you see any downsides?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me - was just curious what our convention was

Copy link
Member Author

@ordian ordian May 8, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that depends on whether the change is breaking, I don't think it is for ethereum-types and primitive-types, but please correct me if I'm wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or if you mean in general, I don't think we should do this in every case, but I'd like to publish new version of primitive-types as well.

Copy link
Contributor

@ascjones ascjones May 8, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes of course my original comment is poorly phrased. Just when I've updated a dependency like this in the past (non breaking minor version) I was unsure about the correct bump for the parent crate.

Copy link
Member Author

@ordian ordian May 8, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sorpaas it seems like latest versions of ethereum-types were published from primitives repo. Can you confirm if that's correct? What's the purpose of ethereum-types in parity-common if so?

authors = ["Parity Technologies <admin@parity.io>"]
license = "MIT"
homepage = "https://github.com/paritytech/parity-common"
Expand All @@ -9,7 +9,7 @@ description = "Ethereum types"
[dependencies]
ethbloom = { path = "../ethbloom", version = "0.6", default-features = false }
fixed-hash = { path = "../fixed-hash", version = "0.3", default-features = false, features = ["byteorder", "rustc-hex"] }
uint = { path = "../uint", version = "0.6", default-features = false }
uint = { path = "../uint", version = "0.7", default-features = false }
primitive-types = { path = "../primitive-types", version = "0.2", features = ["rlp", "byteorder", "rustc-hex"], default-features = false }
impl-serde = { path = "../primitive-types/impls/serde", version = "0.1", default-features = false, optional = true }
impl-rlp = { path = "../primitive-types/impls/rlp", version = "0.1", default-features = false }
Expand Down
4 changes: 2 additions & 2 deletions primitive-types/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
[package]
name = "primitive-types"
version = "0.2.2"
version = "0.2.3"
authors = ["Parity Technologies <admin@parity.io>"]
license = "Apache-2.0/MIT"
homepage = "https://github.com/paritytech/parity-common"
description = "Primitive types shared by Ethereum and Substrate"

[dependencies]
fixed-hash = { version = "0.3", path = "../fixed-hash", default-features = false }
uint = { version = "0.6", path = "../uint", default-features = false }
uint = { version = "0.7", path = "../uint", default-features = false }
impl-serde = { version = "0.1", path = "impls/serde", default-features = false, optional = true }
impl-codec = { version = "0.2", path = "impls/codec", default-features = false, optional = true }
impl-rlp = { version = "0.1", path = "impls/rlp", default-features = false, optional = true }
Expand Down
4 changes: 2 additions & 2 deletions uint/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ homepage = "http://parity.io"
repository = "https://github.com/paritytech/parity-common"
license = "MIT/Apache-2.0"
name = "uint"
version = "0.6.1"
version = "0.7.0"
authors = ["Parity Technologies <admin@parity.io>"]
readme = "README.md"

Expand All @@ -31,7 +31,7 @@ criterion = "0.2.11"
num-bigint = "0.2"

[target.'cfg(unix)'.dev-dependencies]
rug = { version = "1.3.0", default-features = false, features = ["integer"] }
rug = { version = "1.4", default-features = false, features = ["integer"] }

[[bench]]
name = "bigint"
Expand Down