Update codec and crates depending #510

gui1117 · 2021-01-27T09:38:42Z

I think we should wait on the update of scale-info paritytech/scale-info#55

Also I haven't check if some other dependency could be updated alongside.

All in all I just update impl-codec, and then every crate that depends on it directly or indirectly and it ends up updating most crates :-/ is it expected ?

I don't need a release of all crates though I just need a release of primitive-types and impl-codec

ordian

Thanks for taking care of this!

Could you also please update the relevant changelogs (we can publish today) and push git tags when it's merged?
The release process is documented here:
https://github.com/paritytech/parity-common/blob/master/CONTRIBUTING.md#releasing-a-new-version

parity-crypto/Cargo.toml

triehash/Cargo.toml

ordian · 2021-01-27T09:50:07Z

All in all I just update impl-codec, and then every crate that depends on it directly or indirectly and it ends up updating most crates :-/ is it expected ?

Yeah, this is really unfortunate. I'm all ears how can we decouple the dependencies. I guess we need some workaround for rust orphan rules.

ordian · 2021-01-27T10:23:03Z

Seems like it doesn't compile with the scale-info 0.4. We can remove this completely for now as it currently not used anywhere AFAIK.

dvdplm

Ty @thiolliere !

dvdplm · 2021-01-27T10:25:15Z

Seems like it doesn't compile with the scale-info 0.4. We can remove this completely for now as it currently not used anywhere AFAIK.

I haven't looked yet but maybe we should release a 0.5 of scale-info.

cc @ascjones

gui1117 · 2021-01-27T10:27:47Z

I didn't look about other deps that could be bumped, I guess we do want to include
https://github.com/paritytech/parity-common/pull/509/files (actually not sure about tokio)
and
https://github.com/paritytech/parity-common/pull/506/files

ascjones · 2021-01-27T10:29:25Z

Seems like it doesn't compile with the scale-info 0.4. We can remove this completely for now as it currently not used anywhere AFAIK.

It will most likely be required imminently with the work I am doing to integrate scale-info with substrate, e.g. withH256

ordian · 2021-01-27T10:31:18Z

I didn't look about other deps that could be bumped, I guess we do want to include
https://github.com/paritytech/parity-common/pull/509/files (actually not sure about tokio)
and
https://github.com/paritytech/parity-common/pull/506/files

#506 is blocked on #501 (comment)
#509 this is used in openethereum only (we should probably remove it from parity-common: #511), they are still on old tokio

It will most likely be required imminently with the work I am doing to integrate scale-info with substrate, e.g. withH256

please review paritytech/scale-info#55

gui1117 · 2021-01-27T10:47:00Z

push git tags when it's merged

Yes I can do the tag once merged, (but I have not rights to publish those crates)

ordian · 2021-01-27T10:49:17Z

push git tags when it's merged

Yes I can do the tag once merged, (but I have not rights to publish those crates)

you should have rights as a member of core-devs team:

if you find a crate you can't publish, please report, this is fixable with
cargo owner --add github:paritytech:core-devs

gui1117 · 2021-01-27T10:52:05Z

ah ok 👍 then I'll publish and do tags once this is merged, waiting on paritytech/scale-info#55 for now

ascjones · 2021-01-27T12:41:00Z

Released paritytech/scale-info#57

gui1117 · 2021-01-27T14:30:25Z

(looking at how slow is CI, I might merge and release tomorrow)

ordian · 2021-01-27T15:03:56Z

feel free to publish from the branch, the tests seem to pass locally
looks like travis has a long queue, but it seems to catch up: https://travis-ci.org/github/paritytech/parity-common/builds/756413352

* The time crate after 0.2 is unergonomic to use; just use chrono (paritytech#458) The 0.2 series of `time` doesn't make it easy to "just" create a timestamp. The `chrono` crate uses `time` v0.1 and is, I believe, what users like us should be using. So let's just do that. * build(deps): update send_wrapper requirement from 0.3.0 to 0.5.0 (paritytech#461) Updates the requirements on [send_wrapper](https://github.com/thk1/send_wrapper) to permit the latest version. - [Release notes](https://github.com/thk1/send_wrapper/releases) - [Changelog](https://github.com/thk1/send_wrapper/blob/master/CHANGELOG.md) - [Commits](thk1/send_wrapper@v0.3.0...v0.5.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * rlp: add bytes impls (paritytech#459) * rlp: add bytes impls * add tests * rlp: Fix buffer indexing (paritytech#462) * Fix buffer indexing * test for clear * rlp: store test bytes in hex literals (paritytech#465) * Make RLP optional in several crates (paritytech#466) * bump versions and update changelogs (paritytech#463) * update other dependencies (paritytech#471) * ethereum-types/rlp should pull primitive-types/rlp (paritytech#474) * uint: optimize FromStr, make it no_std-compatible (paritytech#468) * Add from_str bench * uint: optimize FromStr, make it no_std-compatible * custom error type * fmt::Display is actually available in core * Error::source for FromHexError * uppercase consts * additional tests * kvdb-rocksdb: replace tempdir with tempfile(paritytech#350) (paritytech#477) * chore(deps): cargo upgrade parking_lot --all (paritytech#470) * chore(deps): cargo upgrade parking_lot --all * chore(deps): bump versions breaking change. * chore: update changelog * kvdb * kvdb-memorydb * kvdb-rocksdb * parity-util-mem * fix nits * fix: kvdb-web add missing changelog entry * fix: bad merge * fix more nits: use breaking label * [kvdb-memorydb]: add `wasm-bindgen` feature flag * grumbles: remove `wasm-bindgen` feature flag * Add hack only in `kvdb-web` * Remove feature flag `wasm-bindgen` from `kvdb-memorydb` * Bump bytes to 1.0 (paritytech#482) * Implement Num from num-traits (paritytech#480) * parity-crypto: remove UB test (paritytech#484) * parity-crypto: remove UB test * rlp: fix unused import * parity-crypto: upgrade deps (paritytech#483) * update some dev-dependencies (paritytech#493) Signed-off-by: koushiro <koushiro.cqx@gmail.com> * fix: make from_str parse 0x-prefixed strings (paritytech#487) * fix: make from_str parse 0x-prefixed strings * fix(uint): make from_str parse 0x-prefixed strings * chore: address review styling comments * fix: tabs instead of spaces * chore: cargo fmt * fix: use strip_prefix instead of starts_with * build(deps): update impl-trait-for-tuples requirement (paritytech#490) Updates the requirements on [impl-trait-for-tuples](https://github.com/bkchr/impl-trait-for-tuples) to permit the latest version. - [Release notes](https://github.com/bkchr/impl-trait-for-tuples/releases) - [Commits](https://github.com/bkchr/impl-trait-for-tuples/commits/v0.2) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * primitive-types: address nits of paritytech#480 (paritytech#485) * primitive-types: address nits of paritytech#480 * fix ethereum-types * Remove deprecated FromStr/TryFrom impls for Secret (paritytech#495) * Remove deprecated FromStr/TryFrom impls for Secret * update CHANGELOG * build(deps): update secp256k1 requirement from 0.19.0 to 0.20.0 (paritytech#496) Updates the requirements on [secp256k1](https://github.com/rust-bitcoin/rust-secp256k1) to permit the latest version. - [Release notes](https://github.com/rust-bitcoin/rust-secp256k1/releases) - [Changelog](https://github.com/rust-bitcoin/rust-secp256k1/blob/master/CHANGELOG.md) - [Commits](https://github.com/rust-bitcoin/rust-secp256k1/commits) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andronik Ordian <write@reusable.software> * build(deps): update smallvec requirement from 0.6.10 to 1.6.0 (paritytech#494) Updates the requirements on [smallvec](https://github.com/servo/rust-smallvec) to permit the latest version. - [Release notes](https://github.com/servo/rust-smallvec/releases) - [Commits](https://github.com/servo/rust-smallvec/commits/v1.6.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andronik Ordian <write@reusable.software> * build(deps): update rand requirement from 0.7.2 to 0.8.0 (paritytech#488) * build(deps): update rand requirement from 0.7.2 to 0.8.0 Updates the requirements on [rand](https://github.com/rust-random/rand) to permit the latest version. - [Release notes](https://github.com/rust-random/rand/releases) - [Changelog](https://github.com/rust-random/rand/blob/master/CHANGELOG.md) - [Commits](rust-random/rand@0.7.3...0.8.0) Signed-off-by: dependabot[bot] <support@github.com> * Seed from u64 * uint: use rand 0.7 for quickcheck feature * kvdb-rocksdb: fix compilation for benches * parity-crypto: remove unused dep and fix a warning * cargo fmt and another unused dep Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andronik Ordian <write@reusable.software> Co-authored-by: David Palm <dvdplm@gmail.com> * build(deps): update rand_xorshift requirement from 0.2.0 to 0.3.0 (paritytech#491) Updates the requirements on [rand_xorshift](https://github.com/rust-random/rngs) to permit the latest version. - [Release notes](https://github.com/rust-random/rngs/releases) - [Commits](https://github.com/rust-random/rngs/commits/rand_xorshift-0.3.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * update changelogs and bump uint (paritytech#486) * update changelogs and bump uint * update ethereum-types changelog * update uint changelog * tabs * fixed-hash: bump to 0.7 * bump keccak-hash to 0.6.0 * contract-address: bump keccak-hash to 0.6 * update changelogs after publishing * bump fs-swap (paritytech#498) * triehash: patch release (paritytech#499) * fix clippy warning (paritytech#504) * add a test for paritytech#507 (paritytech#508) * add a test for paritytech#507 * CI: test uint on a big-endian platform * a workaround for gmp * grumbles * bump byteorder to 1.4.2 * ethereum-types: fix wasm builds for serialize feature (paritytech#503) * ethbloom: do not pull std for 'serialize' feature * ethereum-types: do not pull std for 'serialize' feature * CI: check wasm builds for ethbloom and ethereum-types * fix wasm target * CI: remove redundant check * CI: fix wasm target install * update changelogs * remove parity-runtime (paritytech#511) * Update codec and crates depending (paritytech#510) Co-authored-by: Andronik Ordian <write@reusable.software> Co-authored-by: David <dvdplm@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Artem Vorotnikov <artem@vorotnikov.me> Co-authored-by: Andronik Ordian <write@reusable.software> Co-authored-by: Frost Red Lee <frostredlee@gmail.com> Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com> Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com> Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> Co-authored-by: Xiliang Chen <xlchen1291@gmail.com> Co-authored-by: honeywest <50997103+honeywest@users.noreply.github.com> Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>

update codec and crates depending

3480464

gui1117 mentioned this pull request Jan 27, 2021

Update parity-scale-codec requirement from 1.0.3 to 2.0.0 paritytech/trie#122

Closed

ordian approved these changes Jan 27, 2021

View reviewed changes

parity-crypto/Cargo.toml Show resolved Hide resolved

triehash/Cargo.toml Outdated Show resolved Hide resolved

Update triehash/Cargo.toml

a80c0af

bkchr approved these changes Jan 27, 2021

View reviewed changes

bump parity-crypto

0a0071d

dvdplm approved these changes Jan 27, 2021

View reviewed changes

gui1117 added 2 commits January 27, 2021 11:41

modify changelog

67136dd

fix

96b2f68

ordian added the breaking-change Breaking change label Jan 27, 2021

gui1117 and others added 3 commits January 27, 2021 13:44

update scale-info

1de7587

primitive-types: fix scale-info tests

757423d

fix formatting

df31a16

gui1117 merged commit bb7b437 into master Jan 27, 2021

gui1117 deleted the gui-update-parity-scale-codec branch January 27, 2021 16:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update codec and crates depending #510

Update codec and crates depending #510

gui1117 commented Jan 27, 2021

ordian left a comment

ordian commented Jan 27, 2021

ordian commented Jan 27, 2021

dvdplm left a comment

dvdplm commented Jan 27, 2021

gui1117 commented Jan 27, 2021

ascjones commented Jan 27, 2021

ordian commented Jan 27, 2021 •

edited

Loading

gui1117 commented Jan 27, 2021

ordian commented Jan 27, 2021 •

edited

Loading

gui1117 commented Jan 27, 2021

ascjones commented Jan 27, 2021

gui1117 commented Jan 27, 2021

ordian commented Jan 27, 2021

Update codec and crates depending #510

Update codec and crates depending #510

Conversation

gui1117 commented Jan 27, 2021

ordian left a comment

Choose a reason for hiding this comment

ordian commented Jan 27, 2021

ordian commented Jan 27, 2021

dvdplm left a comment

Choose a reason for hiding this comment

dvdplm commented Jan 27, 2021

gui1117 commented Jan 27, 2021

ascjones commented Jan 27, 2021

ordian commented Jan 27, 2021 • edited Loading

gui1117 commented Jan 27, 2021

ordian commented Jan 27, 2021 • edited Loading

gui1117 commented Jan 27, 2021

ascjones commented Jan 27, 2021

gui1117 commented Jan 27, 2021

ordian commented Jan 27, 2021

ordian commented Jan 27, 2021 •

edited

Loading

ordian commented Jan 27, 2021 •

edited

Loading