-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update codec to 2.0 and release new version (before primitive-types release a new version for codec 2.0) #55
Conversation
I can't understand why CI is failing though |
I think it's because scale-info/.github/workflows/rust.yml Line 46 in 7afea1d
|
Yes we should do a release here, though I'd like to get #53 included so I'll review that now.
I believe we will need to for the release because there are definitely changes in there since the last release e.g. #30 |
No, I'm wrong (well, it is really old), I think you forgot to update this. |
|
Yes CI is successful now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We can bump the derive crate as part of a PR which updates the CHANGELOG
Do you mean you prefer to bump derive crate ? then I can do here it is fine |
I'd be in favour of bumping it here, but either way is fine. |
Yes please |
Yes done |
I'm not sure about this version bump:
substrate doesn't depend on scale-info, but primitive-types does depend optionally on scale-info, and primitive-types will get soon upgraded to 2.0 thus I think it is better if it also update scale-info to 0.5.
Apart from this, it seems we don't need to bump the derive crate, but I'm not sure, maybe it is better not to mix different version of scale-codec when deriving scale-info.
you can take a look at the changelog to make your mind https://github.com/paritytech/parity-scale-codec/blob/master/CHANGELOG.md