This repository has been archived by the owner on Oct 11, 2023. It is now read-only.
Refactor error handling patterns with integration between companions #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joao-paulo-parity
force-pushed
the
jp/error-handling
branch
5 times, most recently
from
c64a12a
to
9bc9cc5
Compare
joao-paulo-parity
force-pushed
the
jp/error-handling
branch
2 times, most recently
from
27c46a8
to
6f6624d
Compare
…better in comments
joao-paulo-parity
force-pushed
the
jp/error-handling
branch
from
6f6624d
to
8ddd03e
Compare
joao-paulo-parity
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In paritytech/substrate#9966 (comment), the first
bot mergefailed because the companion was not mergeable. The problem is that the bot failed silently and did not explain that an error happened.As told by the log line
The problem occurred because the error was not carrying the issue context (otherwise it would have been logged as
WithIssue ...).parity-processbot/src/error.rs
Line 21 in 8e9ea6e
when it reached handle_error
parity-processbot/src/webhook.rs
Line 1638 in 8e9ea6e
In this PR we attempt to improve the error handling so that it's more likely for the bot to correctly report errors as comments.
This PR also addresses some feedback from https://github.com/paritytech/ci_cd/issues/159#issue-939082694 which is mostly related to the companion integration changes.