Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Substrate companion for #9966 #4037

Merged
merged 3 commits into from
Oct 8, 2021
Merged

Substrate companion for #9966 #4037

merged 3 commits into from
Oct 8, 2021

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Oct 8, 2021

No description provided.

@bkchr bkchr added B0-silent Changes should not be mentioned in any release notes A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. C1-low PR touches the given topic and has a low impact on builders. labels Oct 8, 2021
@bkchr bkchr mentioned this pull request Oct 8, 2021
Merged
@bkchr bkchr requested a review from ordian October 8, 2021 08:01
@ghost
Copy link

ghost commented Oct 8, 2021

Waiting for commit status.

@bkchr bkchr force-pushed the bkchr-disalbe-log-reloading-by-default branch from 5d494fb to 0f81329 Compare October 8, 2021 12:16
@bkchr
Copy link
Member Author

bkchr commented Oct 8, 2021

bot merge

@ghost
Copy link

ghost commented Oct 8, 2021

Waiting for commit status.

@ghost
Copy link

ghost commented Oct 8, 2021

Merge aborted: Head SHA changed from 5d494fb to 0f81329

@ghost
Copy link

ghost commented Oct 8, 2021

Merge aborted: Checks failed for 0f81329

@bkchr bkchr added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. label Oct 8, 2021
@bkchr
Copy link
Member Author

bkchr commented Oct 8, 2021

bot merge

@ghost
Copy link

ghost commented Oct 8, 2021

Waiting for commit status.

@ghost
Copy link

ghost commented Oct 8, 2021

Merge aborted: Checks failed for 0f81329

@ordian
Copy link
Member

ordian commented Oct 8, 2021 

   --> node/test/service/src/lib.rs:147:2
    |
147 |     Configuration {
    |     ^^^^^^^^^^^^^ missing `disable_log_reloading`

@bkchr
Copy link
Member Author

bkchr commented Oct 8, 2021

🤦‍♂️

@joao-paulo-parity joao-paulo-parity mentioned this pull request Oct 8, 2021
Merged
@ordian ordian merged commit 1f8021a into master Oct 8, 2021
@ordian ordian deleted the bkchr-disalbe-log-reloading-by-default branch October 8, 2021 15:29
ordian added a commit that referenced this pull request Oct 8, 2021
@ordian
Merge branch 'master' into ao-fix-connectivity-2
a204429 
* master:
  Substrate companion for #9966 (#4037)
  Bump spec_versions (#4041)
  Remove bridges from checks (#4040)
emostov pushed a commit that referenced this pull request Nov 1, 2021
@bkchr @emostov
Substrate companion for #9966 (#4037)
04cd5ba 
* Substrate companion for #9966

* Bump spec_versions

* Update Substrate
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ordian ordian ordian approved these changes

@gilescope gilescope gilescope approved these changes

Assignees
No one assigned
Labels
A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkchr @ordian @gilescope