Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charge core time chains fees for upgrading their runtime code #669

Open
eskimor opened this issue Apr 7, 2023 · 7 comments
Open

Charge core time chains fees for upgrading their runtime code #669

eskimor opened this issue Apr 7, 2023 · 7 comments

Comments

@eskimor
Copy link
Member

eskimor commented Apr 7, 2023 •
edited
Loading

parachains which have won slot auctions are constrained by time on how often they can upgrade their runtime code. We need to charge parathreads for this, as the total number of parathreads is not limited by anything. This could lead to a constant flow of very large code upgrades.

PR: #2372
@Sophia-Gold Sophia-Gold transferred this issue from paritytech/polkadot Aug 24, 2023
@eskimor
Copy link
Member Author

eskimor commented Oct 8, 2023

In fact there is no reason to special case on-demand. We should also charge bulk parachains for upgrades. Idea would be to leave legacy auction parachains as is, but charge all other chains a fee for upgrades.

Reasoning: With coretime, even "bulk" parachains are not really limited in magnitude.

@bkchr
Copy link
Member

bkchr commented Oct 15, 2023

Or we could just increase the time between upgrades, but offer a way for paying to shorten this time to the current default timeout between upgrades.

@eskimor
Copy link
Member Author

eskimor commented Nov 7, 2023 •
edited
Loading

Also, is the deposit for the PVF updated? Or can someone just register a real small runtime and then upgrade to something big without increasing the deposit?

@eskimor
Copy link
Member Author

eskimor commented Nov 8, 2023

@antonva @Szegoo While I can see us launching on-demand on Kusama without fees for upgrading. The issue with the low deposit is a deal breaker. Those two in combination makes it a no-go to launch without a fix, even for Kusama.

@eskimor
Copy link
Member Author

eskimor commented Nov 8, 2023

@Szegoo thanks for looking into this. Whenever you have something, you can request a review from @antonva and me.

This was referenced Nov 10, 2023
Open
Closed
@eskimor eskimor moved this from Backlog to In Progress in parachains team board Dec 5, 2023
@eskimor eskimor changed the title Charge parathreads fees for upgrading their runtime code Charge core time chains fees for upgrading their runtime code Dec 5, 2023
claravanstaden pushed a commit to Snowfork/polkadot-sdk that referenced this issue Dec 8, 2023
@alistair-singh
Upgrade Polkadot dependencies to v0.9.25 (paritytech#669)
5ceed3c 
* update to v0.9.25

* Remove deprecated transactional statements. This is now default behavior.

* remove transaction imports

* fixed account id conversions

* Removed deprecated EnsureOneOf

* runtime upgrades

* Fixed build errors

* panic instead of truncating accounts on conversion

* Revert "Remove deprecated transactional statements. This is now default behavior."

This reverts commit 3c10324c9c45fd3e77be3479c8b39ab32b96700a.

* Revert "remove transaction imports"

This reverts commit a112dbc0a745b739b1042a9565fa63edfce006ff.

* changed order

* updated rust runtime

* updated runtime

* updated readme

* re-enable tests

* rustfmt

* updated test parachain

* upgraded test parachain

* fixed cmd line args

* excluded runtimes

* cargo update

* update polkadot launch

* downgraded tracing to fix logging

* update metadata

* standardlise dependency format

* remove unused import
helin6 pushed a commit to boolnetwork/polkadot-sdk that referenced this issue Feb 5, 2024
@dependabot
Bump actions/checkout from 1 to 3 (paritytech#669)
ed75035 
Bumps [actions/checkout](https://github.com/actions/checkout) from 1 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v1...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@eskimor
Copy link
Member Author

eskimor commented Feb 13, 2024

Partially handled

@eskimor eskimor moved this from In Progress to Backlog in parachains team board Mar 2, 2024
bkchr pushed a commit that referenced this issue Apr 10, 2024
@HCastano @bkchr
Migrate Finality Verifier Pallet to FRAME v2 (#669)
be59072 
* Get pallet compiling with FRAME v2

* Get tests compiling

* Stop printing metadata in tests

* Remove more metadata related code

* Remove unecessary storage attribute
@bkchr
Copy link
Member

bkchr commented May 2, 2024

#2372 (comment) more discussion happened here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
parachains team board
Status: Backlog
Parathreads
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

On-demand & Coretime parachain upgrade fees Szegoo/polkadot-sdk
2 participants
@eskimor @bkchr