Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registrar: Deposit covering max code size #3020

Merged
merged 8 commits into from
Jan 24, 2024
Merged

Registrar: Deposit covering max code size #3020

merged 8 commits into from
Jan 24, 2024

Conversation

Szegoo
Copy link
Contributor

@Szegoo Szegoo commented Jan 22, 2024 •
edited
Loading

This PR implements phase 1 of: #2372 (comment)

NOTE: This means that all the current parachains can upgrade their code to the maximum size for free.

@Szegoo
Copy link
Contributor Author

Szegoo commented Jan 22, 2024

@eskimor @bkchr PTAL.

eskimor
eskimor approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@eskimor eskimor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you @Szegoo !

@eskimor eskimor added the T8-polkadot This PR/Issue is related to/affects the Polkadot network. label Jan 23, 2024
@bkchr bkchr enabled auto-merge January 23, 2024 10:43
@bkchr bkchr added this pull request to the merge queue Jan 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 23, 2024
DrW3RK
DrW3RK reviewed Jan 23, 2024
View reviewed changes
Copy link
Contributor

@DrW3RK DrW3RK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While viewing the code, I noticed a small typo. Good job with identifying this issue and resolving it!

polkadot/runtime/common/src/integration_tests.rs Outdated Show resolved Hide resolved
polkadot/runtime/common/src/integration_tests.rs Outdated Show resolved Hide resolved
polkadot/runtime/common/src/integration_tests.rs Outdated Show resolved Hide resolved
Szegoo and others added 3 commits January 23, 2024 16:38
@Szegoo @DrW3RK
Update polkadot/runtime/common/src/integration_tests.rs
cb315b4 
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
@Szegoo @DrW3RK
Update polkadot/runtime/common/src/integration_tests.rs
676b893 
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
@Szegoo @DrW3RK
Update polkadot/runtime/common/src/integration_tests.rs
3f950e5 
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
kianenigma
kianenigma approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't read the whole conversation leading to this change but the PR does what it says it does ✅

@bkchr bkchr added this pull request to the merge queue Jan 24, 2024
Merged via the queue into paritytech:master with commit 488cbe6 Jan 24, 2024
124 of 125 checks passed
@eskimor eskimor mentioned this pull request Feb 13, 2024
Open
@github-actions github-actions bot mentioned this pull request Mar 13, 2024
Closed
@SBalaguer SBalaguer mentioned this pull request Jun 4, 2024
Closed
@DrW3RK DrW3RK mentioned this pull request Jun 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrW3RK DrW3RK DrW3RK left review comments

@bkchr bkchr bkchr approved these changes

@kianenigma kianenigma kianenigma approved these changes

@eskimor eskimor eskimor approved these changes

Assignees
No one assigned
Labels
T8-polkadot This PR/Issue is related to/affects the Polkadot network.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Szegoo @eskimor @kianenigma @bkchr @DrW3RK