Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move integrity tests feature of insecure-ed-zero #3645

Conversation

girazoki
Copy link
Contributor

Simple PR just moving the insecure-ed-zero only to its appropriate assert

@girazoki girazoki requested a review from a team as a code owner March 11, 2024 13:17
@girazoki
Copy link
Contributor Author

girazoki commented Mar 11, 2024

Also is there a reason why we are only testing maxFreezes and not maxHolds?

@ggwpez
Copy link
Member

ggwpez commented Mar 11, 2024

Also is there a reason why we are only testing maxFreezes and not maxHolds?

Hm i dont think so... please add it then.

@girazoki
Copy link
Contributor Author

Also is there a reason why we are only testing maxFreezes and not maxHolds?

Hm i dont think so... please add it then.

Will do yes

@girazoki
Copy link
Contributor Author

Also is there a reason why we are only testing maxFreezes and not maxHolds?

Hm i dont think so... please add it then.

Ah sorry, it seems there is no need for that according to #2657:

In addition, MaxHolds is removed (as suggested https://github.com/paritytech/polkadot-sdk/pull/2657#discussion_r1443324573) from pallet_balances, and its Holds are now bounded to RuntimeHoldReason::VARIANT_COUNT. Therefore, there is no need to let the runtime specify MaxHolds.

@bkchr bkchr requested a review from ggwpez July 17, 2024 12:48
@bkchr bkchr added the R0-silent Changes should not be mentioned in any release notes label Jul 17, 2024
@bkchr bkchr enabled auto-merge July 17, 2024 12:49
@ggwpez
Copy link
Member

ggwpez commented Jul 17, 2024

Looks like we already did this and this MR became a No-OP. Closing.
Screenshot 2024-07-17 at 23 12 37

@ggwpez ggwpez closed this Jul 17, 2024
auto-merge was automatically disabled July 17, 2024 21:12

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants