[frame] `#[pallet::composite_enum]` improved variant count handling + removed `pallet_balances`'s `MaxHolds` config #2657

bkontur · 2023-12-07T17:11:18Z

I started this investigation/issue based on @liamaharon question here.

Problem

The pallet_balances integrity test should correctly detect that the runtime has correct distinct HoldReasons variant count. I assume the same situation exists for RuntimeFreezeReason.

It is not a critical problem, if we set MaxHolds with a sufficiently large value, everything should be ok. However, in this case, the integrity_test check becomes less useful.

Situation for "any" runtime:

HoldReason enums from different pallets:

        /// from pallet_nis
        #[pallet::composite_enum]
	pub enum HoldReason {
		NftReceipt,
	}

        /// from pallet_preimage
        #[pallet::composite_enum]
	pub enum HoldReason {
		Preimage,
	}

        // from pallet_state-trie-migration
        #[pallet::composite_enum]
	pub enum HoldReason {
		SlashForContinueMigrate,
		SlashForMigrateCustomTop,
		SlashForMigrateCustomChild,
	}

generated RuntimeHoldReason enum looks like:

pub enum RuntimeHoldReason {

    #[codec(index = 32u8)]
    Preimage(pallet_preimage::HoldReason),

    #[codec(index = 38u8)]
    Nis(pallet_nis::HoldReason),

    #[codec(index = 42u8)]
    StateTrieMigration(pallet_state_trie_migration::HoldReason),
}

composite enum RuntimeHoldReason variant count is detected as 3
we set type MaxHolds = ConstU32<3>
pallet_balances::integrity_test is ok with 3(at least 3)

However, the real problem can occur in a live runtime where some functionality might stop working. This is due to a total of 5 distinct hold reasons (for pallets with multi-instance support, it is even more), and not all of them can be used because of an incorrect MaxHolds, which is deemed acceptable according to the integrity_test:

// pseudo-code - if we try to call all of these:

T::Currency::hold(&pallet_nis::HoldReason::NftReceipt.into(), &nft_owner, deposit)?;
T::Currency::hold(&pallet_preimage::HoldReason::Preimage.into(), &nft_owner, deposit)?;
T::Currency::hold(&pallet_state_trie_migration::HoldReason::SlashForContinueMigrate.into(), &nft_owner, deposit)?;

// With `type MaxHolds = ConstU32<3>` these two will fail
T::Currency::hold(&pallet_state_trie_migration::HoldReason::SlashForMigrateCustomTop.into(), &nft_owner, deposit)?;
T::Currency::hold(&pallet_state_trie_migration::HoldReason::SlashForMigrateCustomChild.into(), &nft_owner, deposit)?;

Solutions

A macro #[pallet::*] expansion is extended of VariantCount implementation for the #[pallet::composite_enum] enum type. This expansion generates the VariantCount implementation for pallets' HoldReason, FreezeReason, LockId, and SlashReason. Enum variants must be plain enum values without fields to ensure a deterministic count.

The composite runtime enum, RuntimeHoldReason and RuntimeFreezeReason, now sets VariantCount::VARIANT_COUNT as the sum of pallets' enum VariantCount::VARIANT_COUNT:

#[frame_support::pallet(dev_mode)]
mod module_single_instance {

	#[pallet::composite_enum]
	pub enum HoldReason {
		ModuleSingleInstanceReason1,
		ModuleSingleInstanceReason2,
	}
...
}

#[frame_support::pallet(dev_mode)]
mod module_multi_instance {

	#[pallet::composite_enum]
	pub enum HoldReason<I: 'static = ()> {
		ModuleMultiInstanceReason1,
		ModuleMultiInstanceReason2,
		ModuleMultiInstanceReason3,
	}
...
}


impl self::sp_api_hidden_includes_construct_runtime::hidden_include::traits::VariantCount
    for RuntimeHoldReason
{
    const VARIANT_COUNT: u32 = 0
        + module_single_instance::HoldReason::VARIANT_COUNT
        + module_multi_instance::HoldReason::<module_multi_instance::Instance1>::VARIANT_COUNT
        + module_multi_instance::HoldReason::<module_multi_instance::Instance2>::VARIANT_COUNT
        + module_multi_instance::HoldReason::<module_multi_instance::Instance3>::VARIANT_COUNT;
}

In addition, MaxHolds is removed (as suggested here) from pallet_balances, and its Holds are now bounded to RuntimeHoldReason::VARIANT_COUNT. Therefore, there is no need to let the runtime specify MaxHolds.

For reviewers

Relevant changes can be found here:

substrate/frame/support/procedural/src/lib.rs
substrate/frame/support/procedural/src/pallet/parse/composite.rs
substrate/frame/support/procedural/src/pallet/expand/composite.rs
substrate/frame/support/procedural/src/construct_runtime/expand/composite_helper.rs
substrate/frame/support/procedural/src/construct_runtime/expand/hold_reason.rs
substrate/frame/support/procedural/src/construct_runtime/expand/freeze_reason.rs
substrate/frame/support/src/traits/misc.rs

And the rest of the files is just about removed MaxHolds from pallet_balances

Next steps

Do the same for MaxFreezes #2997.

bkontur · 2023-12-07T17:19:49Z

I think it went unnoticed before because the pallet_balances mock runtime has a TestId enum with three values and type MaxHolds = ConstU32<3>;. The Rococo runtime, for example, has just two pallets with HoldReason, and while each HoldReason has only one value, type MaxHolds = ConstU32<2>; is ok and sufficient.

The issue arises when a HoldReason has more than one value.

bkchr · 2023-12-22T12:43:03Z

@bkontur any problem with this pr? Why not finish it?

…eReason`

bkontur · 2024-01-05T14:36:21Z

bot fmt

bkchr · 2024-01-05T19:13:16Z

substrate/frame/support/src/traits/misc.rs

@@ -37,8 +37,6 @@ pub const DEFENSIVE_OP_PUBLIC_ERROR: &str = "a defensive failure has been trigge
 pub const DEFENSIVE_OP_INTERNAL_ERROR: &str = "Defensive failure has been triggered!";

 /// Trait to get the number of variants in any enum.
-///
-/// NOTE: can be removed once <https://doc.rust-lang.org/std/mem/fn.variant_count.html> is stable.


Why remove this?

well, I think because that nightly feature won't for our result runtime enum RuntimeHoldReason / RuntimeFreezeReason, e.g.: check this gist: https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=57f1091d103a488db9290f637d292e20 .

We need real composite count (sum of inner enum variants), e.g. if we want to remove MaxHolds / MaxFreezes as discussed bellow.

I was even considering renaming the trait VariantCount to `trait CompositeVariantCount."

Or maybe even better, leave VariantCount with that NOTE and use it only for inner enums with #[pallet::composite_enum], so when nighly becomes stable we could remove VariantCount,
and create trait CompositeVariantCount dedicated just to the result runtime enum like RuntimeHoldReason / RuntimeFreezeReason.

So at the end, we will have just CompositeVariantCount.

@bkchr wdyt?

substrate/frame/support/procedural/src/lib.rs

substrate/frame/support/procedural/src/construct_runtime/expand/hold_reason.rs

Co-authored-by: Bastian Köcher <git@kchr.de>

…d/hold_reason.rs Co-authored-by: Bastian Köcher <git@kchr.de>

command-bot · 2024-01-30T23:46:11Z

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5081585 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --pallet=pallet_balances. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-09a0cd55-aa42-49c9-8400-60563e8ebf4a to cancel this command or bot cancel to cancel all commands in this pull request.

…nto HEAD

command-bot · 2024-01-31T04:49:25Z

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --pallet=pallet_balances has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5081585 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5081585/artifacts/download.

liamaharon · 2024-01-31T06:19:31Z

substrate/frame/support/procedural/src/construct_runtime/expand/composite_helper.rs

+		// ```nocompile
+		// pub struct Pallet<T, I = ()>{..}
+		//
+		// #[pallet::composite_enum]
+		// pub enum HoldReason<I: 'static = ()> {..}
+		//
+		// Pallet1: pallet_x,  // <- default type parameter
+		// ```


Is nocompile needed here?

@liamaharon The auto-merge happened faster than I could get to my PC. Thank you, I've created another PR to address your comments: #3150

liamaharon · 2024-01-31T06:20:30Z

substrate/frame/support/procedural/src/lib.rs

@@ -1519,13 +1513,14 @@ pub fn origin(_: TokenStream, _: TokenStream) -> TokenStream {
 ///
 /// ```ignore
 /// Copy, Clone, Eq, PartialEq, Ord, PartialOrd, Encode, Decode, MaxEncodedLen, TypeInfo,
-/// RuntimeDebug
+/// RuntimeDebug,


Suggested change

/// RuntimeDebug,

/// RuntimeDebug

liamaharon · 2024-01-31T06:21:18Z

substrate/frame/support/procedural/src/pallet/expand/composite.rs

+use crate::pallet::Def;
+use proc_macro2::TokenStream;
+
+/// Expands `composite_enum` and adds the `VariantCount` implementation for it."


Suggested change

/// Expands `composite_enum` and adds the `VariantCount` implementation for it."

/// Expands `composite_enum` and adds the `VariantCount` implementation for it.

liamaharon · 2024-01-31T06:21:58Z

substrate/frame/support/procedural/src/pallet/parse/composite.rs

+	pub ident: syn::Ident,
+	/// Type parameters and where clause attached to a declaration of the pallet::composite_enum.


Suggested change

pub ident: syn::Ident,

/// Type parameters and where clause attached to a declaration of the pallet::composite_enum.

pub ident: syn::Ident,

/// Type parameters and where clause attached to a declaration of the pallet::composite_enum.

@liamaharon

… removed `pallet_balances`'s `MaxHolds` config (paritytech#2657) I started this investigation/issue based on @liamaharon question [here](paritytech#1801 (comment)). ## Problem The `pallet_balances` integrity test should correctly detect that the runtime has correct distinct `HoldReasons` variant count. I assume the same situation exists for RuntimeFreezeReason. It is not a critical problem, if we set `MaxHolds` with a sufficiently large value, everything should be ok. However, in this case, the integrity_test check becomes less useful. **Situation for "any" runtime:** - `HoldReason` enums from different pallets: ```rust /// from pallet_nis #[pallet::composite_enum] pub enum HoldReason { NftReceipt, } /// from pallet_preimage #[pallet::composite_enum] pub enum HoldReason { Preimage, } // from pallet_state-trie-migration #[pallet::composite_enum] pub enum HoldReason { SlashForContinueMigrate, SlashForMigrateCustomTop, SlashForMigrateCustomChild, } ``` - generated `RuntimeHoldReason` enum looks like: ```rust pub enum RuntimeHoldReason { #[codec(index = 32u8)] Preimage(pallet_preimage::HoldReason), #[codec(index = 38u8)] Nis(pallet_nis::HoldReason), #[codec(index = 42u8)] StateTrieMigration(pallet_state_trie_migration::HoldReason), } ``` - composite enum `RuntimeHoldReason` variant count is detected as `3` - we set `type MaxHolds = ConstU32<3>` - `pallet_balances::integrity_test` is ok with `3`(at least 3) However, the real problem can occur in a live runtime where some functionality might stop working. This is due to a total of 5 distinct hold reasons (for pallets with multi-instance support, it is even more), and not all of them can be used because of an incorrect `MaxHolds`, which is deemed acceptable according to the `integrity_test`: ``` // pseudo-code - if we try to call all of these: T::Currency::hold(&pallet_nis::HoldReason::NftReceipt.into(), &nft_owner, deposit)?; T::Currency::hold(&pallet_preimage::HoldReason::Preimage.into(), &nft_owner, deposit)?; T::Currency::hold(&pallet_state_trie_migration::HoldReason::SlashForContinueMigrate.into(), &nft_owner, deposit)?; // With `type MaxHolds = ConstU32<3>` these two will fail T::Currency::hold(&pallet_state_trie_migration::HoldReason::SlashForMigrateCustomTop.into(), &nft_owner, deposit)?; T::Currency::hold(&pallet_state_trie_migration::HoldReason::SlashForMigrateCustomChild.into(), &nft_owner, deposit)?; ``` ## Solutions A macro `#[pallet::*]` expansion is extended of `VariantCount` implementation for the `#[pallet::composite_enum]` enum type. This expansion generates the `VariantCount` implementation for pallets' `HoldReason`, `FreezeReason`, `LockId`, and `SlashReason`. Enum variants must be plain enum values without fields to ensure a deterministic count. The composite runtime enum, `RuntimeHoldReason` and `RuntimeFreezeReason`, now sets `VariantCount::VARIANT_COUNT` as the sum of pallets' enum `VariantCount::VARIANT_COUNT`: ```rust #[frame_support::pallet(dev_mode)] mod module_single_instance { #[pallet::composite_enum] pub enum HoldReason { ModuleSingleInstanceReason1, ModuleSingleInstanceReason2, } ... } #[frame_support::pallet(dev_mode)] mod module_multi_instance { #[pallet::composite_enum] pub enum HoldReason<I: 'static = ()> { ModuleMultiInstanceReason1, ModuleMultiInstanceReason2, ModuleMultiInstanceReason3, } ... } impl self::sp_api_hidden_includes_construct_runtime::hidden_include::traits::VariantCount for RuntimeHoldReason { const VARIANT_COUNT: u32 = 0 + module_single_instance::HoldReason::VARIANT_COUNT + module_multi_instance::HoldReason::<module_multi_instance::Instance1>::VARIANT_COUNT + module_multi_instance::HoldReason::<module_multi_instance::Instance2>::VARIANT_COUNT + module_multi_instance::HoldReason::<module_multi_instance::Instance3>::VARIANT_COUNT; } ``` In addition, `MaxHolds` is removed (as suggested [here](paritytech#2657 (comment))) from `pallet_balances`, and its `Holds` are now bounded to `RuntimeHoldReason::VARIANT_COUNT`. Therefore, there is no need to let the runtime specify `MaxHolds`. ## For reviewers Relevant changes can be found here: - `substrate/frame/support/procedural/src/lib.rs` - `substrate/frame/support/procedural/src/pallet/parse/composite.rs` - `substrate/frame/support/procedural/src/pallet/expand/composite.rs` - `substrate/frame/support/procedural/src/construct_runtime/expand/composite_helper.rs` - `substrate/frame/support/procedural/src/construct_runtime/expand/hold_reason.rs` - `substrate/frame/support/procedural/src/construct_runtime/expand/freeze_reason.rs` - `substrate/frame/support/src/traits/misc.rs` And the rest of the files is just about removed `MaxHolds` from `pallet_balances` ## Next steps Do the same for `MaxFreezes` paritytech#2997. --------- Co-authored-by: command-bot <> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Dónal Murray <donal.murray@parity.io> Co-authored-by: gupnik <nikhilgupta.iitk@gmail.com>

* Setup deps * Remove Koi from account migration test * paritytech/polkadot-sdk#1495 * Bump * paritytech/polkadot-sdk#1524 * !! paritytech/polkadot-sdk#1363 * paritytech/polkadot-sdk#1492 * paritytech/polkadot-sdk#1911 * paritytech/polkadot-sdk#1900 Signed-off-by: Xavier Lau <xavier@inv.cafe> * paritytech/polkadot-sdk#1661 * paritytech/polkadot-sdk#2144 * paritytech/polkadot-sdk#2048 * paritytech/polkadot-sdk#1672 * paritytech/polkadot-sdk#2303 * paritytech/polkadot-sdk#1256 * Remove identity and vesting * Fixes * paritytech/polkadot-sdk#2657 * paritytech/polkadot-sdk#1313 * paritytech/polkadot-sdk#2331 * paritytech/polkadot-sdk#2409 part.1 * paritytech/polkadot-sdk#2767 * paritytech/polkadot-sdk#2521 Signed-off-by: Xavier Lau <xavier@inv.cafe> * paritytech/polkadot-sdk#1222 * paritytech/polkadot-sdk#1234 part.1 * Satisfy compiler * XCM V4 part.1 * paritytech/polkadot-sdk#1246 * Remove pallet-democracy part.1 * paritytech/polkadot-sdk#2142 * paritytech/polkadot-sdk#2428 * paritytech/polkadot-sdk#3228 * XCM V4 part.2 * Bump * Build all runtimes * Build node * Remove pallet-democracy Signed-off-by: Xavier Lau <xavier@inv.cafe> * Format * Fix pallet tests * Fix precompile tests * Format * Fixes * Async, remove council, common pallet config * Fix `ethtx-forward` test case (#1519) * Fix ethtx-forward tests * Format * Fix following the review * Fixes * Fixes * Use default impl * Benchmark helper * Bench part.1 * Bench part.2 * Bench part.3 * Fix all tests * Typo * Feat * Fix EVM tracing build * Reuse upstream `proof_size_base_cost()` (#1521) * Format issue * Fixes * Fix CI --------- Signed-off-by: Xavier Lau <xavier@inv.cafe> Co-authored-by: Bear Wang <boundless.forest@outlook.com>

bkontur mentioned this pull request Dec 7, 2023

Refactor pallet-state-trie-migration to fungible::* traits #1801

Merged

5 tasks

bkontur added 7 commits January 5, 2024 11:38

Test for MaxHolds

746732c

wip

d1dba07

Dedicated test for composite_enum and variant count

535a883

Fix HoldReason and FreezeReason variant count

2e8a925

Fix macro for no composite enums

b752f74

impl Get<u32> for RuntimeFreezeReason/RuntimeHoldReason

80c685c

Set all MaxHolds = RuntimeHoldReason and `MaxFreezes = RuntimeFreez…

a2b272a

…eReason`

bkontur force-pushed the bko-max-holds-integrity-test branch from a8745ef to a2b272a Compare January 5, 2024 14:32

bkontur changed the base branch from bko-pallet-nicks-refactor to master January 5, 2024 14:35

".git/.scripts/commands/fmt/fmt.sh"

694d230

bkontur added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Jan 5, 2024

bkontur changed the title ~~Test for MaxHolds vs integrity_test~~ [frame] #[pallet::composite_enum] improved variant count handling Jan 5, 2024

bkontur marked this pull request as ready for review January 5, 2024 14:45

bkontur requested review from a team January 5, 2024 14:45

Docs fix

a0dd0a8

bkchr reviewed Jan 5, 2024

View reviewed changes

Update substrate/frame/support/procedural/src/lib.rs

71156bb

Co-authored-by: Bastian Köcher <git@kchr.de>

paritytech-review-bot bot requested a review from a team January 8, 2024 08:38

bkontur and others added 7 commits January 8, 2024 09:44

Fix other places with Basti's suggestion

2f3c31c

Update substrate/frame/support/procedural/src/lib.rs

6d6e75c

Co-authored-by: Bastian Köcher <git@kchr.de>

Update substrate/frame/support/procedural/src/lib.rs

b84cc1b

Co-authored-by: Bastian Köcher <git@kchr.de>

Update substrate/frame/support/procedural/src/lib.rs

4f5c9c8

Co-authored-by: Bastian Köcher <git@kchr.de>

fix

b30e17e

Update substrate/frame/support/procedural/src/construct_runtime/expan…

b38ddb2

…d/hold_reason.rs Co-authored-by: Bastian Köcher <git@kchr.de>

Update substrate/frame/support/procedural/src/construct_runtime/expan…

8d9bdf0

…d/hold_reason.rs Co-authored-by: Bastian Köcher <git@kchr.de>

command-bot added 8 commits January 31, 2024 00:51

".git/.scripts/commands/bench-all/bench-all.sh" --pallet=pallet_balances

0ce9eca

Merge branch 'master' of https://github.com/paritytech/polkadot-sdk i…

3aeb0f8

…nto HEAD

".git/.scripts/commands/bench-all/bench-all.sh" --pallet=pallet_balances

998ed0f

".git/.scripts/commands/bench-all/bench-all.sh" --pallet=pallet_balances

53b2f44

".git/.scripts/commands/bench-all/bench-all.sh" --pallet=pallet_balances

e6552cc

".git/.scripts/commands/bench-all/bench-all.sh" --pallet=pallet_balances

2d6a3c4

".git/.scripts/commands/bench-all/bench-all.sh" --pallet=pallet_balances

27a5723

".git/.scripts/commands/bench-all/bench-all.sh" --pallet=pallet_balances

adbcace

svyatonik approved these changes Jan 31, 2024

View reviewed changes

bkontur added this pull request to the merge queue Jan 31, 2024

liamaharon approved these changes Jan 31, 2024

View reviewed changes

Merged via the queue into master with commit bb8ddc4 Jan 31, 2024
124 checks passed

bkontur deleted the bko-max-holds-integrity-test branch January 31, 2024 06:58

bkontur added a commit that referenced this pull request Jan 31, 2024

Addressing Liam's comments from #2657

53e786d

github-merge-queue bot pushed a commit that referenced this pull request Jan 31, 2024

Addressing Liam's comments from #2657 (#3150)

a03ef27

bkontur added a commit to bkontur/runtimes that referenced this pull request Feb 16, 2024

[pallet_balances] adapt paritytech/polkadot-sdk#2657 (removed MaxHolds)

703e674

bkontur mentioned this pull request Mar 11, 2024

[FRAME] Try to calculate MaxHolds/MxFreezes automatically #2000

Open

girazoki mentioned this pull request Mar 11, 2024

move integrity tests feature of insecure-ed-zero #3645

Closed

github-actions bot mentioned this pull request Mar 13, 2024

Update polkadot-sdk from v1.3.0 to v1.7.2 moonbeam-foundation/moonbeam#2703

Closed

bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024

Addressing Liam's comments from paritytech#2657 (paritytech#3150)

00e60b1

This was referenced Apr 8, 2024

Update Substrate to 1.8.0 autonomys/subspace#2667

Merged

Proper value for the HoldIdentifier::VARIANT_COUNT autonomys/subspace#2674

Open

Generalize VariantCount into InstanceCount #4033

Open

bkontur mentioned this pull request May 16, 2024

Ensure correct variant count in Runtime[Hold/Freeze]Reason #1900

Merged

AurevoirXavier added a commit to darwinia-network/darwinia that referenced this pull request Jun 24, 2024

paritytech/polkadot-sdk#2657

0357ab3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[frame] `#[pallet::composite_enum]` improved variant count handling + removed `pallet_balances`'s `MaxHolds` config #2657

[frame] `#[pallet::composite_enum]` improved variant count handling + removed `pallet_balances`'s `MaxHolds` config #2657

bkontur commented Dec 7, 2023 •

edited

Loading

bkontur commented Dec 7, 2023

bkchr commented Dec 22, 2023

bkontur commented Jan 5, 2024

bkchr Jan 5, 2024

bkontur Jan 8, 2024

command-bot bot commented Jan 30, 2024 •

edited

Loading

command-bot bot commented Jan 31, 2024

liamaharon Jan 31, 2024

bkontur Jan 31, 2024

liamaharon Jan 31, 2024

liamaharon Jan 31, 2024

liamaharon Jan 31, 2024

	/// Expands `composite_enum` and adds the `VariantCount` implementation for it."
	/// Expands `composite_enum` and adds the `VariantCount` implementation for it.

		pub ident: syn::Ident,
		/// Type parameters and where clause attached to a declaration of the pallet::composite_enum.

[frame] #[pallet::composite_enum] improved variant count handling + removed pallet_balances's MaxHolds config #2657

[frame] #[pallet::composite_enum] improved variant count handling + removed pallet_balances's MaxHolds config #2657

Conversation

bkontur commented Dec 7, 2023 • edited Loading

Problem

Solutions

For reviewers

Next steps

bkontur commented Dec 7, 2023

bkchr commented Dec 22, 2023

bkontur commented Jan 5, 2024

bkchr Jan 5, 2024

Choose a reason for hiding this comment

bkontur Jan 8, 2024

Choose a reason for hiding this comment

command-bot bot commented Jan 30, 2024 • edited Loading

command-bot bot commented Jan 31, 2024

liamaharon Jan 31, 2024

Choose a reason for hiding this comment

bkontur Jan 31, 2024

Choose a reason for hiding this comment

liamaharon Jan 31, 2024

Choose a reason for hiding this comment

liamaharon Jan 31, 2024

Choose a reason for hiding this comment

liamaharon Jan 31, 2024

Choose a reason for hiding this comment

[frame] `#[pallet::composite_enum]` improved variant count handling + removed `pallet_balances`'s `MaxHolds` config #2657

[frame] `#[pallet::composite_enum]` improved variant count handling + removed `pallet_balances`'s `MaxHolds` config #2657

bkontur commented Dec 7, 2023 •

edited

Loading

command-bot bot commented Jan 30, 2024 •

edited

Loading