Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FRAME: Revamp Preimage pallet to use Consideration #1363

Merged
merged 55 commits into from
Sep 17, 2023

Conversation

gavofyork
Copy link
Member

@gavofyork gavofyork commented Sep 2, 2023

Make Preimage pallet use Consideration instead of handling deposits directly.

Other half of paritytech/substrate#13666.
Depends/based on #1361.

Script for the lazy migration that should be run manually once: migrate-preimage-lazy.py.

TODO

  • Migration code.

@gavofyork gavofyork added the T2-pallets This PR/Issue is related to a particular pallet. label Sep 2, 2023
@gavofyork gavofyork changed the title Frame: Revamp Preimage pallet to use Consideration FRAME: Revamp Preimage pallet to use Consideration Sep 2, 2023
@gavofyork gavofyork force-pushed the gav-consideration-preimage branch from bcf6b0a to 9e2dd10 Compare September 3, 2023 10:37
@gavofyork gavofyork marked this pull request as ready for review September 3, 2023 11:14
gavofyork and others added 9 commits September 6, 2023 12:51
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Copy link
Member

ggwpez commented Sep 6, 2023

bot bench substrate-pallet --pallet=pallet_preimage

@command-bot
Copy link

command-bot bot commented Sep 6, 2023

@ggwpez https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3593250 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_preimage. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-0ac52503-4b00-40f4-9768-a8a9466dc8ce to cancel this command or bot cancel to cancel all commands in this pull request.

…=dev --target_dir=substrate --pallet=pallet_preimage
@command-bot
Copy link

command-bot bot commented Sep 6, 2023

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_preimage has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3593250 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3593250/artifacts/download.

@gavofyork gavofyork disabled auto-merge September 17, 2023 11:19
@gavofyork gavofyork merged commit d787269 into master Sep 17, 2023
6 checks passed
@gavofyork gavofyork deleted the gav-consideration-preimage branch September 17, 2023 11:19
svyatonik added a commit to svyatonik/runtimes that referenced this pull request Nov 3, 2023
[requires migration. onchain or offchain?]
@xlc xlc mentioned this pull request Nov 15, 2023
3 tasks
bkchr added a commit to polkadot-fellows/runtimes that referenced this pull request Nov 20, 2023
In the PR we bump versions for all dependacy crates from `polkadot-sdk`
and apply all required changes

Changes:
- `parachains_runtime_api_impl` `v5` -> `v7`,
  - from paritytech/polkadot-sdk#1543;
- `Consideration` setup for preimage pallet instances,
  - from  paritytech/polkadot-sdk#1363;
- `experimental` feature removed for `pallet-society`, `pallet-xcm`,
`runtime-common` crates,
  - from paritytech/polkadot-sdk#1503;
- `pallet_election_provider_multi_phase::Config::SignedDepositBase` set
to `GeometricDepositBase`,
  - from paritytech/polkadot-sdk#1547;
- support `open_outbound_hrmp_channel_for_benchmarks_or_tests` func
rename,
  - from paritytech/polkadot-sdk#1422;
- missing weight functions added for `runtime_parachains_hrmp` and
`pallet_preimage`;

TODO:
- [x] Deleted the Copy&paste para scheduler migration from
#26 in
b666613. This should be applied in the
next runtime upgrade, but i did not properly check yet.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v1-2-0/4451/2

HCastano added a commit to entropyxyz/entropy-core that referenced this pull request Jan 19, 2024
HCastano added a commit to entropyxyz/entropy-core that referenced this pull request Jan 23, 2024
* Get `entropy-shared` compiling with updated deps

* Fix `entropy-shared` build for `wasm-no-std`

* Make `pallet-staking-extension` compile

Starts introducing some of the changes brought in by
paritytech/polkadot-sdk#1484.

* Introduce staking changes from paritytech/substrate#12970

* Add RuntimeFreezeReason from paritytech/polkadot-sdk#1900

* Re-map errors in staking extension pallet

* Bump `pallet-programs`

* Missed a crate dep for staking extension

* Remove commented out code

* Get `pallet-relayer` compiling

* Fix relayer test compilation

* Fix `pallet-free-tx`'s tests

* Reorder config types

* Bump `pallet-propagation` dependencies

* Bump `pallet-slashing` dependencies

* Bump `pallet-transaction-pause`

This includes the deprecation of `Balances::transfer` from
paritytech/polkadot-sdk#1226.

* TaploFmt

* Use `StakingAccount` instead of `.into()`

* Import `vec` macro in `pallet-slashing`

* Import `vec` in other pallets

* Bump TOML dependencies for runtime

Haven't fixed the Rust code yet though

* Self define types instead of using `node-primitives`

* Update staking related configs

Values were mostly taken from the Polkadot runtime config

* Update `pallet-preimage` config

Changes introduced in paritytech/polkadot-sdk#1363

* Add `MaxNominators` to `pallet_babe`

Introduced in paritytech/substrate#14471

* Add `MaxNominators` to `pallet_grandpa`

Also introduced in paritytech/substrate#14471

* Add `RuntimeFreezeReason` to `pallet_nomination_pools`

* Add `MaxTipAmount` to `pallet_tips`

Introduced in paritytech/polkadot-sdk#1709

* Add `IdentityInformation` to `pallet_identity`

Introduced in paritytech/polkadot-sdk#1661

* finish runtime

* Use `crates.io` packages in `entropy` TOML

This doesn't compile yet

* Remove reference to `node_primitives`

* Move imports under correct dependency section

These shouldn't be built-deps, my bad

* Change `WarpSyncParams` import to come from `sc_network_sync`

Change introduced here: paritytech/polkadot-sdk#1912

* Add missing `sc-consensus-babe` package

* Remove second generic from `DefaultImportQueue`

This was removed in paritytech/substrate#14612

* Add temporary cursed RPC bounds

* Switch `sp-consensus-grandpa` to be from Crates

* Add Grandpa justification period to service

* Rename `justification_period to` `justification_generation_period`

* Add missing `block_relay` param

Introduced in paritytech/polkadot-sdk#1524

* Try to clean up runtime types

* Add `opaque` types to runtime

These match what was in `node-primitives`. In particular we're interested in the `Block` type which
we were using in a lot of places, and I incorrectly changed to be `Unchechecked` instead of
`Opaque`.

* Use opaque block type in service

* Add full session key impls

* Remove cursed trait bounds for RPC

* Convert some tabs to spaces

Sorry, I had to

* Import `Vec` from `sp_std` in benchmarks

Turns out the issue responsible for this change is this:
paritytech/polkadot-sdk#172

* Pull `TrackedStorageKey` from `sp_storage`

From here: paritytech/substrate#14787

* Add `BenchmarkHelper` to treasury pallet

* TaploFmt

* change max freezes

* Sort TOML imports in runtime manifest

* Move `version` field to be first in runtime manifest

* Organize imports in pallet manifests

* Sort and organize imports for client

* Address TODOs in `entropy-shared`

* Remove TODOs related to `node-primitives`

* Pull `substrate-wasm-builder` from crates.io

* TaploFmt

* Fix benchmarking import post-merge

* Fix another program import port-merge

* Import `Vec` to programs benches

* Wrong vec import 🙃

* Poke CI

* Bump node metadata

---------

Co-authored-by: Jesse Abramowitz <jesse@entropy.xyz>
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
Make Preimage pallet use Consideration instead of handling deposits
directly.

Other half of paritytech/substrate#13666.
Depends/based on paritytech#1361.

Script for the lazy migration that should be run manually once:
[migrate-preimage-lazy.py](https://github.com/ggwpez/substrate-scripts/blob/master/migrate-preimage-lazy.py).

## TODO

- [x] Migration code.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: command-bot <>
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
enddynayn pushed a commit to frequency-chain/frequency that referenced this pull request May 28, 2024
Upgrade Polkadot v1.1.0 to v1.2.0.
[Polkadot release notes](https://forum.polkadot.network/t/polkadot-release-analysis-v1-2-0/4451)

Lazy Migration
paritytech/polkadot-sdk#1363

Update weights.

issue-1718
enddynayn pushed a commit to frequency-chain/frequency that referenced this pull request May 28, 2024
Upgrade Polkadot v1.1.0 to v1.2.0.
[Polkadot release notes](https://forum.polkadot.network/t/polkadot-release-analysis-v1-2-0/4451)

Lazy Migration
paritytech/polkadot-sdk#1363

Update weights.

issue-1718
enddynayn added a commit to frequency-chain/frequency that referenced this pull request May 29, 2024
# Goal
Update polkadot from v1.1.0 to v1.2.0.

[Polkadot release
notes](https://forum.polkadot.network/t/polkadot-release-analysis-v1-2-0/4451)

Lazy Migration
paritytech/polkadot-sdk#1363

Closes #1718

Co-authored-by: Enddy Dumbrique <enddy.dumbrique@amplica.com>
AurevoirXavier added a commit to darwinia-network/darwinia that referenced this pull request Jun 21, 2024
AurevoirXavier added a commit to darwinia-network/darwinia that referenced this pull request Jun 28, 2024
* Setup deps

* Remove Koi from account migration test

* paritytech/polkadot-sdk#1495

* Bump

* paritytech/polkadot-sdk#1524

* !! paritytech/polkadot-sdk#1363

* paritytech/polkadot-sdk#1492

* paritytech/polkadot-sdk#1911

* paritytech/polkadot-sdk#1900

Signed-off-by: Xavier Lau <xavier@inv.cafe>

* paritytech/polkadot-sdk#1661

* paritytech/polkadot-sdk#2144

* paritytech/polkadot-sdk#2048

* paritytech/polkadot-sdk#1672

* paritytech/polkadot-sdk#2303

* paritytech/polkadot-sdk#1256

* Remove identity and vesting

* Fixes

* paritytech/polkadot-sdk#2657

* paritytech/polkadot-sdk#1313

* paritytech/polkadot-sdk#2331

* paritytech/polkadot-sdk#2409 part.1

* paritytech/polkadot-sdk#2767

* paritytech/polkadot-sdk#2521

Signed-off-by: Xavier Lau <xavier@inv.cafe>

* paritytech/polkadot-sdk#1222

* paritytech/polkadot-sdk#1234 part.1

* Satisfy compiler

* XCM V4 part.1

* paritytech/polkadot-sdk#1246

* Remove pallet-democracy part.1

* paritytech/polkadot-sdk#2142

* paritytech/polkadot-sdk#2428

* paritytech/polkadot-sdk#3228

* XCM V4 part.2

* Bump

* Build all runtimes

* Build node

* Remove pallet-democracy

Signed-off-by: Xavier Lau <xavier@inv.cafe>

* Format

* Fix pallet tests

* Fix precompile tests

* Format

* Fixes

* Async, remove council, common pallet config

* Fix `ethtx-forward` test case (#1519)

* Fix ethtx-forward tests

* Format

* Fix following the review

* Fixes

* Fixes

* Use default impl

* Benchmark helper

* Bench part.1

* Bench part.2

* Bench part.3

* Fix all tests

* Typo

* Feat

* Fix EVM tracing build

* Reuse upstream `proof_size_base_cost()` (#1521)

* Format issue

* Fixes

* Fix CI

---------

Signed-off-by: Xavier Lau <xavier@inv.cafe>
Co-authored-by: Bear Wang <boundless.forest@outlook.com>
rustadot pushed a commit to rustadot/recurrency that referenced this pull request Sep 5, 2024
# Goal
Update polkadot from v1.1.0 to v1.2.0.

[Polkadot release
notes](https://forum.polkadot.network/t/polkadot-release-analysis-v1-2-0/4451)

Lazy Migration
paritytech/polkadot-sdk#1363

Closes #1718

Co-authored-by: Enddy Dumbrique <enddy.dumbrique@amplica.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
Status: Done
Status: Audited
Development

Successfully merging this pull request may close these issues.

5 participants