-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preimages now use RequestStatusFor #10141
Comments
Also mentioned on this issue, every action related to preimages won't work such as governance using |
Hey, @dnjscksdn98, I noticed the same issue as new preimages are no longer shown in the "Preimages" tab of governance. I guess this is expected because of what you mentioned above. I do see also a bunch of errors in the console |
cc @TarikGul could you look into this? I just found this issue while submitting a fellowship proposal. Came here to report it but the issue already exists. |
@andresilva Thanks for pinging me. I'll have a look into this. Just getting back into the swing of things this week, so response times should be faster :) |
Okay so good news is I was able to reproduce the issue and also semi-fix it. The only problem being giving support for both storage entries is a little tricky (there is quite a lot of abstraction happening with all the hooks and page refs). None the less I will find a solution soon! Thanks for the patience. |
Fixed via: #10310 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query. |
Due to the major update on
pallet-preimage
(ref.), it seems that the original storage valueStatusFor
has been deprecated and nowRequestStatusFor
is used instead.But it seems that the preimage page (ref.) are only referencing to the
StatusFor
field.So for chains that had upgraded their runtime higher than
v1.2.0
(that contains the upper-mentioned PR), will have some incompatibility among preimages. I guess the stored preimage data is fine, but it's just the data display issue on the page.In my opinion, both
StatusFor
andRequestStatusFor
should be supported. The reason is because some chains might not yet upgraded their runtime, or either, the lazy storage migration might not have been done.Version:
Environment:
Language:
The text was updated successfully, but these errors were encountered: