Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preimages now use RequestStatusFor #10141

Closed
1 of 10 tasks
dnjscksdn98 opened this issue Jan 4, 2024 · 7 comments
Closed
1 of 10 tasks

Preimages now use RequestStatusFor #10141

dnjscksdn98 opened this issue Jan 4, 2024 · 7 comments
Assignees

Comments

@dnjscksdn98
Copy link
Contributor

  • I'm submitting a ...
  • Bug report
  • Feature request
  • Support request
  • Other
  • What is the current behavior and expected behavior?
    Due to the major update on pallet-preimage (ref.), it seems that the original storage value StatusFor has been deprecated and now RequestStatusFor is used instead.
    But it seems that the preimage page (ref.) are only referencing to the StatusFor field.
    So for chains that had upgraded their runtime higher than v1.2.0 (that contains the upper-mentioned PR), will have some incompatibility among preimages. I guess the stored preimage data is fine, but it's just the data display issue on the page.
    In my opinion, both StatusFor and RequestStatusFor should be supported. The reason is because some chains might not yet upgraded their runtime, or either, the lazy storage migration might not have been done.
스크린샷 2024-01-04 오후 1 42 57
  • What is the motivation for changing the behavior?
  • Please tell us about your environment:
  • Version:

  • Environment:

    • Node.js
    • Browser
    • Other (limited support for other environments)
  • Language:

    • JavaScript
    • TypeScript (include tsc --version)
    • Other
@dnjscksdn98
Copy link
Contributor Author

Also mentioned on this issue, every action related to preimages won't work such as governance using pallet-democracy. The issues that I've encountered was that even though the proposal has been passed, pallet-scheduler wasn't able to call the proposal emitting a CallUnavailable event.

@albertov19
Copy link
Contributor

Hey, @dnjscksdn98, I noticed the same issue as new preimages are no longer shown in the "Preimages" tab of governance. I guess this is expected because of what you mentioned above.

I do see also a bunch of errors in the console

@andresilva
Copy link
Contributor

cc @TarikGul could you look into this? I just found this issue while submitting a fellowship proposal. Came here to report it but the issue already exists.

@TarikGul
Copy link
Member

TarikGul commented Feb 26, 2024

@andresilva Thanks for pinging me. I'll have a look into this.

Just getting back into the swing of things this week, so response times should be faster :)

@TarikGul
Copy link
Member

Okay so good news is I was able to reproduce the issue and also semi-fix it. The only problem being giving support for both storage entries is a little tricky (there is quite a lot of abstraction happening with all the hooks and page refs). None the less I will find a solution soon! Thanks for the patience.

@TarikGul
Copy link
Member

Fixed via: #10310

@github-project-automation github-project-automation bot moved this from Issues (Bugs) to Done in Polkadot-js general project board Feb 29, 2024
@polkadot-js-bot
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

5 participants