Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PJS browser app is not listing all on-chain Governance->Preimages #10288

Closed
2 of 7 tasks
acatangiu opened this issue Feb 22, 2024 · 3 comments · Fixed by #10310
Closed
2 of 7 tasks

PJS browser app is not listing all on-chain Governance->Preimages #10288

acatangiu opened this issue Feb 22, 2024 · 3 comments · Fixed by #10310
Assignees

Comments

@acatangiu
Copy link

  • I'm submitting a ...

    • Bug report
    • Feature request
    • Support request
    • Other
  • What is the current behavior and expected behavior?

For some chains (saw this on PolkadotCollectives and Kusama, but possibly others), PJS is not showing all Preimages that are still on-chain.

For example, this preimage was submitted to Collectives: https://collectives.statescan.io/#/extrinsics/3201877-2
and on-chain preimage 0x953d2a661349cbbf2f7f14af56bad37393a54d1878b593fc4ee9e893bd7eb1ba is not showing up in Governance -> Preimages.

Doing a bit of debugging, it seems that PJS is:

only listing the items found using deprecated pallet_preimage::StatusFor storage

Screenshot 2024-02-22 at 17 01 05

and not listing items found using new pallet_preimage::RequestStatusFor storage item.

Screenshot 2024-02-22 at 17 01 22

  • What is the motivation for changing the behavior?

Preimages should show up in the PJS GUI for a number of reasons:

  • it allows easy listing
  • it allows easy decoding and inspection of preimages
  • it allows easy access to un-note and refund deposit once it is no longer needed
  • governance proposals using preimages will correctly render the inner call (when PJS can find and decode the preimage)
  • Please tell us about your environment:

    • Version: apps v0.133.2-87

    • Environment:

      • Node.js
      • Browser
      • Other (limited support for other environments)
@TarikGul
Copy link
Member

rel: #10141

Going to try and tackle both issues at the same time.

@TarikGul
Copy link
Member

Fixed via: #10310

@polkadot-js-bot
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants