-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support requestStatusFor for usePreimage #10310
Conversation
Okay so I did some testing with kusama, and this should fix in all the areas that use |
@TarikGul Unfortunately this breaks backwards compatibility with chains which still run on Polkadot v0.9.43. Centrifuge is one of these. We cannot access the |
Interesting, I didn't remove any of the old calls, or old logic. Let me see the issue. |
@wischli Okay I found the issue, PR to resolve this will be up soon. |
@wischli Should be fixed. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
closes: #10288, #10141
Due to the deprecation of
StatusFor
given paritytech/polkadot-sdk#1363 theusePreimage
hook needs to support bothStatusFor
andRequestStatusFor
calls when gathering data for preimage hashes.