Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support requestStatusFor for usePreimage #10310

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Conversation

TarikGul
Copy link
Member

closes: #10288, #10141

Due to the deprecation of StatusFor given paritytech/polkadot-sdk#1363 the usePreimage hook needs to support both StatusFor and RequestStatusFor calls when gathering data for preimage hashes.

@TarikGul TarikGul changed the title support requestStatusFor for usePreimage Support requestStatusFor for usePreimage Feb 29, 2024
@TarikGul TarikGul added the -auto label Feb 29, 2024
@polkadot-js-bot polkadot-js-bot merged commit 44691fb into master Feb 29, 2024
7 checks passed
@polkadot-js-bot polkadot-js-bot deleted the tarik-preimage-change branch February 29, 2024 21:33
@TarikGul
Copy link
Member Author

Okay so I did some testing with kusama, and this should fix in all the areas that use usePreimage. The only page that is a little unknown at the moment and is not related to this specifically is the whitelist page which will be investigated seperately

@wischli
Copy link
Contributor

wischli commented Mar 1, 2024

@TarikGul Unfortunately this breaks backwards compatibility with chains which still run on Polkadot v0.9.43. Centrifuge is one of these. We cannot access the Preimages page anymore, which basically block users from being able to preimages and therefore referenda as well as council motions. Could you please re-add support for the old API as well?

@TarikGul
Copy link
Member Author

TarikGul commented Mar 1, 2024

@TarikGul Unfortunately this breaks backwards compatibility with chains which still run on Polkadot v0.9.43. Centrifuge is one of these. We cannot access the Preimages page anymore, which basically block users from being able to preimages and therefore referenda as well as council motions. Could you please re-add support for the old API as well?

Interesting, I didn't remove any of the old calls, or old logic. Let me see the issue.

@TarikGul
Copy link
Member Author

TarikGul commented Mar 1, 2024

@wischli Okay I found the issue, PR to resolve this will be up soon.

@TarikGul
Copy link
Member Author

TarikGul commented Mar 1, 2024

@wischli Should be fixed.

@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

PJS browser app is not listing all on-chain Governance->Preimages
3 participants