Update Polkadot ideal staking rate #26
Conversation
Co-authored-by: Gonçalo Pestana <g6pestana@gmail.com>
| @@ -130,7 +130,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion { | |||
| spec_name: create_runtime_str!("polkadot"), | |||
| impl_name: create_runtime_str!("parity-polkadot"), | |||
| authoring_version: 0, | |||
| spec_version: 9430, | |||
| spec_version: 1_000_000, | |||
There was a problem hiding this comment.
@liamaharon i dont see a warning in the try-runtime-cli that the spec version did not increase when i use the runtime from master (1dc04eb).
Could you check please?
There was a problem hiding this comment.
That's no good.. Will check it tomorrow and write back here.
There was a problem hiding this comment.
It does check and log a warning, but maybe you missed it because it logs before running the migrations and is easily missed.
I've created an issue to move the warning log to after the migrations execute and make it more obvious paritytech/try-runtime-cli#45
| if let Ref::Ongoing(ref_status) = reff { | ||
| Some((idx, ref_status)) | ||
| } else { | ||
| None |
There was a problem hiding this comment.
We can eventually clean all the old Referenda, or? Currently they just seem to bloat storage.
The new society is at the same index as the old one, but has different `calls`.
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
| total_stakable: Balance, | ||
| max_annual_inflation: Perquintill, | ||
| period_fraction: Perquintill, | ||
| auctioned_slots: u64, |
There was a problem hiding this comment.
I dont remember the current status, but back when this was originally written, i believe the auctioned slots counter was not exactly correct.
has this logic been updated?
| /// See <https://forum.polkadot.network/t/adjusting-polkadots-ideal-staking-rate-calculation/3897>. | ||
| fn polkadot_era_payout( | ||
| total_staked: Balance, | ||
| total_stakable: Balance, |
There was a problem hiding this comment.
i also think it would be sensible to peek in on what this value currently is on Polkadot and ensure it makes sense.
This is a backport from polkadot-sdk master that includes some fixes.
In the PR we bump versions for all dependacy crates from `polkadot-sdk` and apply all required changes Changes: - `parachains_runtime_api_impl` `v5` -> `v7`, - from paritytech/polkadot-sdk#1543; - `Consideration` setup for preimage pallet instances, - from paritytech/polkadot-sdk#1363; - `experimental` feature removed for `pallet-society`, `pallet-xcm`, `runtime-common` crates, - from paritytech/polkadot-sdk#1503; - `pallet_election_provider_multi_phase::Config::SignedDepositBase` set to `GeometricDepositBase`, - from paritytech/polkadot-sdk#1547; - support `open_outbound_hrmp_channel_for_benchmarks_or_tests` func rename, - from paritytech/polkadot-sdk#1422; - missing weight functions added for `runtime_parachains_hrmp` and `pallet_preimage`; TODO: - [x] Deleted the Copy&paste para scheduler migration from #26 in b666613. This should be applied in the next runtime upgrade, but i did not properly check yet. --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
as per https://forum.polkadot.network/t/adjusting-polkadots-ideal-staking-rate-calculation/3897/2.