Deprecate NativeElseWasmExecutor
#4329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The native executor is deprecated and downstream users should stop using it.
davxy
approved these changes
Apr 30, 2024
| @@ -558,6 +566,7 @@ where | |||
|
|
|||
| /// A generic `CodeExecutor` implementation that uses a delegate to determine wasm code equivalence | |||
| /// and dispatch to native code when possible, falling back on `WasmExecutor` when not. | |||
| #[deprecated(note = "Native execution will be deprecated, please replace with `WasmExecutor`")] | |||
There was a problem hiding this comment.
nit: should we indicate estimated removal date?
| @@ -263,10 +263,13 @@ where | |||
| } | |||
|
|
|||
| /// Creates a [`NativeElseWasmExecutor`] according to [`Configuration`]. | |||
| #[deprecated(note = "Please switch to `new_wasm_executor`.")] | |||
There was a problem hiding this comment.
nit: the same - removal date could be given.
michalkucharczyk
approved these changes
Apr 30, 2024
lexnv
approved these changes
Apr 30, 2024
|
The CI pipeline was cancelled due to failure one of the required jobs. |
skunert
approved these changes
Apr 30, 2024
seadanda
approved these changes
May 2, 2024
dcolley
added a commit
to metaspan/polkadot-sdk
that referenced
this pull request
May 6, 2024
* 'master' of https://github.com/metaspan/polkadot-sdk: (65 commits) Introduces `TypeWithDefault<T, D: Get<T>>` (paritytech#4034) Publish `polkadot-sdk-frame` crate (paritytech#4370) Add validate field to prdoc (paritytech#4368) State trie migration on asset-hub westend and collectives westend (paritytech#4185) Fix: dust unbonded for zero existential deposit (paritytech#4364) Bridge: added subcommand to relay single parachain header (paritytech#4365) Bridge: fix zombienet tests (paritytech#4367) [WIP][CI] Add more GHA jobs (paritytech#4270) Allow for 0 existential deposit in benchmarks for `pallet_staking`, `pallet_session`, and `pallet_balances` (paritytech#4346) Deprecate `NativeElseWasmExecutor` (paritytech#4329) More `xcm::v4` cleanup and `xcm_fee_payment_runtime_api::XcmPaymentApi` nits (paritytech#4355) sc-tracing: enable env-filter feature (paritytech#4357) deps: update jsonrpsee to v0.22.5 (paritytech#4330) Add PoV-reclaim enablement guide to polkadot-sdk-docs (paritytech#4244) cargo: Update experimental litep2p to latest version (paritytech#4344) Bridge: ignore client errors when calling recently added `*_free_headers_interval` methods (paritytech#4350) Make parachain template great again (and async backing ready) (paritytech#4295) [Backport] Version bumps and reorg prdocs from 1.11.0 (paritytech#4336) HRMP - set `DefaultChannelSizeAndCapacityWithSystem` with dynamic values according to the `ActiveConfig` (paritytech#4332) Statement Distribution Per Peer Rate Limit (paritytech#3444) ...
2 tasks
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
The native executor is deprecated and downstream users should stop using it.
This was referenced Aug 13, 2024
This was referenced Aug 21, 2024
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The native executor is deprecated and downstream users should stop using it.