Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to 1.10.0 #182

Merged
merged 64 commits into from
Aug 15, 2024
Merged

Conversation

chungquantin
Copy link
Collaborator

@chungquantin chungquantin commented Aug 13, 2024

Status: ✅ Tested on my local devnet, testnet => Block production / finalization + submit extrinsic works well.

References

Direct changes

  • [#3696]: Add HRMP notification handlers to the xcm-executor
  • [#3844]: Add the ability for MessageQueue to process enqueued messages on idle
  • [#3350]: removed pallet::getter from Pallet AURA
  • [#3654]: Remove experimental feature from pallet-aura

Export unified ParachainHostFunctions #3854: Exports ParachainHostFunctions to have a bundled version of SubstrateHostFunctions and cumulus_primitives_proof_size_hostfunction::storage_proof_size::HostFunctions. This increases discoverability and makes it more obvious that they should be used together in parachain nodes.

With the introduction of this upgrade, we might need a refactor in the node service.rs to replace the NativeExecutionDispatch implementation with the WasmExecutor<HostFunctions> (See this example). NativeElseWasmExecutor will soon be deprecated in v1.12.0 through the PR 4329

Other updates that might be related

  • [#3471]: removed pallet::getter from cumulus pallets
  • [#3749]: pallet-xcm: deprecate execute and send in favor of execute_blob and send_blob

pallet-contracts takes the XCM encoded now as well. It follows the same API as execute_blob and send_blob.

  • [#3607]: XCM fee payment API

@chungquantin chungquantin mentioned this pull request Aug 13, 2024
7 tasks
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 10.74%. Comparing base (389a2b9) to head (764e41d).

Files Patch % Lines
node/src/service.rs 0.00% 24 Missing ⚠️
node/src/command.rs 0.00% 2 Missing ⚠️
runtime/devnet/src/lib.rs 0.00% 1 Missing ⚠️
runtime/testnet/src/lib.rs 0.00% 1 Missing ⚠️
@@              Coverage Diff              @@
##           developer     #182      +/-   ##
=============================================
+ Coverage      10.58%   10.74%   +0.15%     
=============================================
  Files             27       27              
  Lines           2135     2104      -31     
  Branches        2135     2104      -31     
=============================================
  Hits             226      226              
+ Misses          1909     1878      -31     
Files Coverage Δ
runtime/devnet/src/config/xcm.rs 0.00% <ø> (ø)
runtime/testnet/src/config/xcm.rs 0.00% <ø> (ø)
runtime/devnet/src/lib.rs 14.88% <0.00%> (ø)
runtime/testnet/src/lib.rs 14.88% <0.00%> (ø)
node/src/command.rs 0.00% <0.00%> (ø)
node/src/service.rs 0.00% <0.00%> (ø)

@chungquantin chungquantin self-assigned this Aug 13, 2024
Copy link
Collaborator

@peterwht peterwht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice!! Great PR description, and the cleanup in the service file is awesome.

Only thing is the removal of the benchmarking host function. Please see comment below.

node/src/service.rs Show resolved Hide resolved
node/src/service.rs Show resolved Hide resolved
@peterwht
Copy link
Collaborator

[sc-917]

@chungquantin
Copy link
Collaborator Author

Questions: Even though the devnet and testnet can run successfully in this PR with the migration to unified parachain host functions. Do we need to add back the signed extra for POV reclaim feature? Because like we discussed, both runtime should not have this feature enabled.

cc: @al3mart @peterwht

@al3mart
Copy link
Collaborator

al3mart commented Aug 15, 2024

Indeed @chungquantin, it seems that we will be better leaving those out of the runtimes for now. Some fixes involving POV reclaim have been back-ported upstream, but only to 1.14

@chungquantin
Copy link
Collaborator Author

Indeed @chungquantin, it seems that we will be better leaving those out of the runtimes for now. Some fixes involving POV reclaim have been back-ported upstream, but only to 1.14

@al3mart I see, thanks for the reference. Hence, this PR is ready for review!

Copy link
Collaborator

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

It would have been great doing a refactor to include a mod for the runtime api impl as in #3817, though it is not strictly necessary for the version bump. 👍 I guess can be tackled in a future change.

Another one that could be handy once we catch up with 1.14 is adding XcmPaymentApi.

@chungquantin chungquantin merged commit 620a857 into developer Aug 15, 2024
7 of 8 checks passed
@chungquantin chungquantin deleted the chungquantin/chore-polkadot-v1.10.0 branch August 15, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants