-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to 1.10.0 #182
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## developer #182 +/- ##
=============================================
+ Coverage 10.58% 10.74% +0.15%
=============================================
Files 27 27
Lines 2135 2104 -31
Branches 2135 2104 -31
=============================================
Hits 226 226
+ Misses 1909 1878 -31
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice!! Great PR description, and the cleanup in the service file is awesome.
Only thing is the removal of the benchmarking host function. Please see comment below.
[sc-917] |
…hore-polkadot-v1.10.0
…polkadot-v1.10.0' into chungquantin/chore-polkadot-v1.10.0
Co-authored-by: Peter White <petras9789@gmail.com>
…polkadot-v1.10.0' into chungquantin/chore-polkadot-v1.10.0
Questions: Even though the |
Indeed @chungquantin, it seems that we will be better leaving those out of the runtimes for now. Some fixes involving POV reclaim have been back-ported upstream, but only to 1.14 |
@al3mart I see, thanks for the reference. Hence, this PR is ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
It would have been great doing a refactor to include a mod for the runtime api impl as in #3817, though it is not strictly necessary for the version bump. 👍 I guess can be tackled in a future change.
Another one that could be handy once we catch up with 1.14 is adding XcmPaymentApi
.
Status: ✅ Tested on my local
devnet
,testnet
=> Block production / finalization + submit extrinsic works well.References
pallet-contracts
:v1.9.0
andv1.10.0
pallet-xcm
:v1.9.0
andv1.10.0
Direct changes
pallet::getter
from Pallet AURAexperimental
feature frompallet-aura
Export unified ParachainHostFunctions #3854: Exports ParachainHostFunctions to have a bundled version of SubstrateHostFunctions and
cumulus_primitives_proof_size_hostfunction::storage_proof_size::HostFunctions
. This increases discoverability and makes it more obvious that they should be used together in parachain nodes.With the introduction of this upgrade, we might need a refactor in the node
service.rs
to replace theNativeExecutionDispatch
implementation with theWasmExecutor<HostFunctions>
(See this example).NativeElseWasmExecutor
will soon be deprecated in v1.12.0 through the PR 4329Other updates that might be related
pallet::getter
from cumulus palletspallet-contracts
takes the XCM encoded now as well. It follows the same API asexecute_blob
andsend_blob
.