This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Companion PR for #7136 (WeightInfo for Session / Offences) #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for commit status. |
shawntabrizi
added
B0-silent
|
Head SHA changed; merge aborted. |
shawntabrizi
added
the
A2-insubstantial
shawntabrizi
commented
Sep 21, 2020
| @@ -57,31 +56,6 @@ fn weight_of_system_set_code_is_correct() { | |||
| assert_eq!(weight, expected_weight); | |||
| } | |||
|
|
|||
| #[test] | |||
There was a problem hiding this comment.
We remove these tests because the weights no longer come from downstream Substrate, but we define them locally in the Repo.
ordian
approved these changes
Sep 21, 2020
andresilva
approved these changes
Sep 21, 2020
expenses
approved these changes
Sep 21, 2020
andresilva
reviewed
Sep 21, 2020
At least it should be done before next release |
@shawntabrizi 😬 lets do this and get this merged, please! |
|
It will be done all in one final PR to avoid back to back merge conflicts. Even if we dont, the values we get for substrate would be fine anyway. (but it will be done) |
|
bot merge |
|
Trying merge. |
ghost
merged commit 
ordian
added a commit
that referenced
this pull request
Sep 23, 2020
* master: Update to substrate 2.0 (#1744) Companion: Handle construct_runtime breaking change. (#1692) Companion for `ModuleToIndex` to `PalletInfo` rename (#1743) Companion for substrate/pull/7161 (#1739) Companion for 7155 (WeightInfo for Babe and Grandpa) (#1736) Companion PR for #7136 (WeightInfo for Session / Offences) (#1735)
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple PR that removes the
WeightInfotrade for pallet_offences (as the weight information should come from the different implementations ofOnOffence.paritytech/substrate#7136