This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
*: Update authority discovery and remove WorkerConfig #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With paritytech/substrate#7545 the authority discovery module queries and publishes addresses on an exponentially increasing interval. Doing so should make custom configurations obsolete, as operations are retried in a timely fashion in the first minutes.
mxinden
added
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
A4-companion
A PR that needs a companion PR to merge in parallel for one of its downstream dependencies.
C1-low
PR touches the given topic and has a low impact on builders.
A1-needsburnin
labels
Nov 16, 2020
ordian
approved these changes
Nov 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good as a companion. And I don't have a strong opinion whether the WorkerConfig
should be exposed or not as @bkchr.
Waiting for commit status. |
@mxinden could you please resolve merge conflicts? |
Checks failed; merge aborted. |
ordian
added
A8-mergeoncegreen
and removed
A0-please_review
Pull request needs code review.
A1-needsburnin
labels
Nov 23, 2020
bkchr
approved these changes
Nov 23, 2020
bot merge |
Waiting for commit status. |
ghost
deleted the
mxinden-auth-disc-timing
branch
November 23, 2020 18:23
ordian
added a commit
that referenced
this pull request
Nov 24, 2020
* master: backing: reorder votes to match bitfield in backed candidate (#2006) Switch to wasm-builder 3.0.0 (#2004) Make sure we inform statement listeners about received statements (#1999) Update docker.md (#2000) Bump tracing from 0.1.21 to 0.1.22 (#2001) Bump assert_cmd from 1.0.1 to 1.0.2 (#2003) Bump color-eyre from 0.5.7 to 0.5.8 (#2002) *: Update authority discovery and remove WorkerConfig (#1953) companion for substrate#7546 (#1954)
ordian
added a commit
that referenced
this pull request
Nov 24, 2020
* master: backing: reorder votes to match bitfield in backed candidate (#2006) Switch to wasm-builder 3.0.0 (#2004) Make sure we inform statement listeners about received statements (#1999) Update docker.md (#2000) Bump tracing from 0.1.21 to 0.1.22 (#2001) Bump assert_cmd from 1.0.1 to 1.0.2 (#2003) Bump color-eyre from 0.5.7 to 0.5.8 (#2002) *: Update authority discovery and remove WorkerConfig (#1953) companion for substrate#7546 (#1954)
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A4-companion
A PR that needs a companion PR to merge in parallel for one of its downstream dependencies.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With paritytech/substrate#7545 the authority
discovery module queries and publishes addresses on an exponentially
increasing interval. Doing so should make custom configurations
obsolete, as operations are retried in a timely fashion in the first
minutes.
This is a companion for paritytech/substrate#7545.