Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

*: Update authority discovery and remove WorkerConfig #1953

Merged
11 commits merged into from
Nov 23, 2020

Conversation

mxinden
Copy link
Contributor

@mxinden mxinden commented Nov 16, 2020

With paritytech/substrate#7545 the authority
discovery module queries and publishes addresses on an exponentially
increasing interval. Doing so should make custom configurations
obsolete, as operations are retried in a timely fashion in the first
minutes.

This is a companion for paritytech/substrate#7545.

With paritytech/substrate#7545 the authority
discovery module queries and publishes addresses on an exponentially
increasing interval. Doing so should make custom configurations
obsolete, as operations are retried in a timely fashion in the first
minutes.
@mxinden mxinden added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. C1-low PR touches the given topic and has a low impact on builders. A1-needsburnin labels Nov 16, 2020
@mxinden mxinden requested a review from bkchr November 16, 2020 16:51
@mxinden
Copy link
Contributor Author

mxinden commented Nov 16, 2020

When reviewing, please ignore 0785943 which needs to be reverted before merging. Reverted in 765bab1.

@mxinden mxinden requested a review from ordian November 19, 2020 13:43
@mxinden
Copy link
Contributor Author

mxinden commented Nov 19, 2020

@bkchr @ordian would you mind giving this pull request a review?

Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good as a companion. And I don't have a strong opinion whether the WorkerConfig should be exposed or not as @bkchr.

@mxinden
Copy link
Contributor Author

mxinden commented Nov 23, 2020

And I don't have a strong opinion whether the WorkerConfig should be exposed or not as @bkchr.

Am I correctly interpreting your silence as approval @bkchr?

@ghost
Copy link

ghost commented Nov 23, 2020

Waiting for commit status.

@ordian
Copy link
Member

ordian commented Nov 23, 2020

@mxinden could you please resolve merge conflicts?

@ghost
Copy link

ghost commented Nov 23, 2020

Checks failed; merge aborted.

@mxinden
Copy link
Contributor Author

mxinden commented Nov 23, 2020

I reverted the commit pushed by the bot (377b221), merged master and ran cargo update -p sp-io.

@ordian is that the right approach here?

@ordian ordian added A8-mergeoncegreen and removed A0-please_review Pull request needs code review. A1-needsburnin labels Nov 23, 2020
@bkchr
Copy link
Member

bkchr commented Nov 23, 2020

bot merge

@ghost
Copy link

ghost commented Nov 23, 2020

Waiting for commit status.

@ghost ghost merged commit ab5dd44 into master Nov 23, 2020
@ghost ghost deleted the mxinden-auth-disc-timing branch November 23, 2020 18:23
ordian added a commit that referenced this pull request Nov 24, 2020
* master:
  backing: reorder votes to match bitfield in backed candidate (#2006)
  Switch to wasm-builder 3.0.0 (#2004)
  Make sure we inform statement listeners about received statements (#1999)
  Update docker.md (#2000)
  Bump tracing from 0.1.21 to 0.1.22 (#2001)
  Bump assert_cmd from 1.0.1 to 1.0.2 (#2003)
  Bump color-eyre from 0.5.7 to 0.5.8 (#2002)
  *: Update authority discovery and remove WorkerConfig (#1953)
  companion for substrate#7546 (#1954)
ordian added a commit that referenced this pull request Nov 24, 2020
* master:
  backing: reorder votes to match bitfield in backed candidate (#2006)
  Switch to wasm-builder 3.0.0 (#2004)
  Make sure we inform statement listeners about received statements (#1999)
  Update docker.md (#2000)
  Bump tracing from 0.1.21 to 0.1.22 (#2001)
  Bump assert_cmd from 1.0.1 to 1.0.2 (#2003)
  Bump color-eyre from 0.5.7 to 0.5.8 (#2002)
  *: Update authority discovery and remove WorkerConfig (#1953)
  companion for substrate#7546 (#1954)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants