This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
backing: reorder votes to match bitfield in backed candidate #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-please_review
|
I've checked this fix (although with my local implementation of the fix) and it worked without any inherent problems. Thus, can you also remove this one? |
coriolinus
approved these changes
Nov 24, 2020
montekki
approved these changes
Nov 24, 2020
That is a separate thing, which I don't feel comfortable removing at this time. If there is a bug in candidate backing or bitfield selection which causes the validators to always attempt to author blocks with invalid inherent, I would rather halt all parachains than halt the relay chain. |
ordian
added a commit
that referenced
this pull request
Nov 24, 2020
* master: backing: reorder votes to match bitfield in backed candidate (#2006) Switch to wasm-builder 3.0.0 (#2004) Make sure we inform statement listeners about received statements (#1999) Update docker.md (#2000) Bump tracing from 0.1.21 to 0.1.22 (#2001) Bump assert_cmd from 1.0.1 to 1.0.2 (#2003) Bump color-eyre from 0.5.7 to 0.5.8 (#2002) *: Update authority discovery and remove WorkerConfig (#1953) companion for substrate#7546 (#1954)
ordian
added a commit
that referenced
this pull request
Nov 24, 2020
* master: backing: reorder votes to match bitfield in backed candidate (#2006) Switch to wasm-builder 3.0.0 (#2004) Make sure we inform statement listeners about received statements (#1999) Update docker.md (#2000) Bump tracing from 0.1.21 to 0.1.22 (#2001) Bump assert_cmd from 1.0.1 to 1.0.2 (#2003) Bump color-eyre from 0.5.7 to 0.5.8 (#2002) *: Update authority discovery and remove WorkerConfig (#1953) companion for substrate#7546 (#1954)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a bug raised by @pepyakin and adds a test case that failed before and passes now.