Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

cleanup validator discovery #1992

Merged
5 commits merged into from
Nov 20, 2020
Merged

cleanup validator discovery #1992

5 commits merged into from
Nov 20, 2020

Conversation

ordian
Copy link
Member

@ordian ordian commented Nov 20, 2020

This PR:

@ordian ordian added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Nov 20, 2020
@ordian ordian mentioned this pull request Nov 20, 2020
Merged
coriolinus
coriolinus approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@coriolinus coriolinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I'm surprised that authority_discovery_service.get_addresses_by_authority_id would return more than MAX_ADDRESSES_PER_PEER for a single ID, but agree that we should remove all of a peer's addresses, not a subset of them.

bkchr
bkchr approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't even aware that we could model all this behavior much easier as you have done it now. Nice 👍

@montekki
Copy link
Contributor

bot merge

@ghost
Copy link

ghost commented Nov 20, 2020

Trying merge.

@ghost ghost merged commit f4897f7 into master Nov 20, 2020
@ghost ghost deleted the ao-cleanup-validator-discovery branch November 20, 2020 18:34
ordian added a commit that referenced this pull request Nov 23, 2020
@ordian
Merge branch 'master' into ao-session-info
d50073b 
* master:
  Improve collator side of the collator-protocol (#1955)
  add parity-keyring to install instructions (#1993)
  sane messaging defaults (#1994)
  cleanup validator discovery (#1992)
  Add Prometheus timers to the subsystems (#1923)
  Add tracing support to node (#1940)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coriolinus coriolinus coriolinus approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ordian @montekki @bkchr @coriolinus