This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
validator_discovery: cache by (Hash, ParaId) #2402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
added
A0-please_review
bkchr
approved these changes
Feb 8, 2021
|
How will it interact if we make multiple requests for the same validator under the different ParaIds? e.g. how we intend to use it in availability recovery / approval checking? |
AFAIK, availability recovery does not use this API. But it would work just fine. We would issue a second request and if the validator is already connected, we'd send the result immediately. Cleanup also works correctly, we have to deal with reference counting of requested validators anyway. |
rphmeier
deleted the
ao-cache-validator-connection-requets-per-hash-and-paraid
branch
ordian
added a commit
that referenced
this pull request
Feb 11, 2021
* master: Implement Approval Voting Subsystem (#2112) Introduce PerPeerSet utility that allows to segrate based on PeerSet (#2420) [CI] Move check_labels to github actions (#2415) runtime: set equivocation report longevity (#2404) Companion for #7936: Migrate pallet-balances to pallet attribute macro (#2331) Corrected Physical (#2414) validator_discovery: cache by (Hash, ParaId) (#2402) Enable wasmtime caching for PVF (companion for #8057) (#2387) Use construct_runtime in tests, remove default PalletInfo impl (#2409) validator_discovery: pass PeerSet to the request (#2372) guide: more robust approval counting procedure (#2378) Publish rococo on every push to `rococo-v1` branch (#2388) Bump trie-db from 0.22.2 to 0.22.3 (#2344) Send view to new peers (#2392)
ordian
added a commit
that referenced
this pull request
Feb 11, 2021
* master: Implement Approval Voting Subsystem (#2112) Introduce PerPeerSet utility that allows to segrate based on PeerSet (#2420) [CI] Move check_labels to github actions (#2415) runtime: set equivocation report longevity (#2404) Companion for #7936: Migrate pallet-balances to pallet attribute macro (#2331) Corrected Physical (#2414) validator_discovery: cache by (Hash, ParaId) (#2402) Enable wasmtime caching for PVF (companion for #8057) (#2387) Use construct_runtime in tests, remove default PalletInfo impl (#2409) validator_discovery: pass PeerSet to the request (#2372) guide: more robust approval counting procedure (#2378) Publish rococo on every push to `rococo-v1` branch (#2388) Bump trie-db from 0.22.2 to 0.22.3 (#2344) Send view to new peers (#2392)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2372 (comment).