Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Introduce PerPeerSet utility that allows to segrate based on PeerSet #2420

Merged
2 commits merged into from
Feb 11, 2021
Merged

Introduce PerPeerSet utility that allows to segrate based on PeerSet #2420

2 commits merged into from
Feb 11, 2021

Conversation

pepyakin
Copy link
Contributor

No description provided.

@pepyakin pepyakin added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Feb 11, 2021
@pepyakin pepyakin requested a review from ordian February 11, 2021 14:06
ordian
ordian approved these changes Feb 11, 2021
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion on this, but if we go this route, we might as well remove [repr(usize)] on PeerSet.

bkchr
bkchr approved these changes Feb 11, 2021
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@bkchr
Copy link
Member

bkchr commented Feb 11, 2021

bot merge

@ghost
Copy link

ghost commented Feb 11, 2021

Waiting for commit status.

@ghost ghost merged commit 4377176 into master Feb 11, 2021
@ghost ghost deleted the ser-embrace-index branch February 11, 2021 14:40
ordian added a commit that referenced this pull request Feb 11, 2021
@ordian
merge master
d61c753 
* master:
  Implement Approval Voting Subsystem (#2112)
  Introduce PerPeerSet utility that allows to segrate based on PeerSet (#2420)
  [CI] Move check_labels to github actions (#2415)
  runtime: set equivocation report longevity (#2404)
  Companion for #7936: Migrate pallet-balances to pallet attribute macro (#2331)
  Corrected Physical (#2414)
  validator_discovery: cache by (Hash, ParaId) (#2402)
  Enable wasmtime caching for PVF (companion for #8057) (#2387)
  Use construct_runtime in tests, remove default PalletInfo impl (#2409)
  validator_discovery: pass PeerSet to the request (#2372)
  guide: more robust approval counting procedure (#2378)
  Publish rococo on every push to `rococo-v1` branch (#2388)
  Bump trie-db from 0.22.2 to 0.22.3 (#2344)
  Send view to new peers (#2392)
ordian added a commit that referenced this pull request Feb 11, 2021
@ordian
merge master
f1f6178 
* master:
  Implement Approval Voting Subsystem (#2112)
  Introduce PerPeerSet utility that allows to segrate based on PeerSet (#2420)
  [CI] Move check_labels to github actions (#2415)
  runtime: set equivocation report longevity (#2404)
  Companion for #7936: Migrate pallet-balances to pallet attribute macro (#2331)
  Corrected Physical (#2414)
  validator_discovery: cache by (Hash, ParaId) (#2402)
  Enable wasmtime caching for PVF (companion for #8057) (#2387)
  Use construct_runtime in tests, remove default PalletInfo impl (#2409)
  validator_discovery: pass PeerSet to the request (#2372)
  guide: more robust approval counting procedure (#2378)
  Publish rococo on every push to `rococo-v1` branch (#2388)
  Bump trie-db from 0.22.2 to 0.22.3 (#2344)
  Send view to new peers (#2392)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ordian ordian ordian approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pepyakin @bkchr @ordian