This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
disable approval-checking voting rule on polkadot #3321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
added
A0-please_review
ordian
force-pushed
the
ao-disable-overseer-for-polkadot
branch
2 times, most recently
from
9045a96
to
d972673
Compare
ordian
changed the title
ordian
added
A0-please_review
ordian
force-pushed
the
ao-disable-overseer-for-polkadot
branch
from
66a3118
to
4edf07d
Compare
andresilva
approved these changes
Jun 20, 2021
rphmeier
approved these changes
Jun 20, 2021
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit
andresilva
added a commit
that referenced
this pull request
Jun 20, 2021
andresilva
added a commit
that referenced
this pull request
Jun 21, 2021
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please let me know if I should instead create
is_polkadotcheck on chain spec.Before #3133 approval checking didn't change the grandpa vote if
ApprovedAncestorreturnedNone(which is the case if there is no parachains runtime, which is the case on Polkadot). But that PR changed that and is deployed on 0.9.5.This PR disables
ApprovalCheckingVotingRuleon Polkadot altogether, because it doesn't make sense to run it until we have parachains runtime there.